Identity API: Add token cache and identity.invalidateAuthToken.

Identity API: Add token cache and identity.invalidateAuthToken.

Identity.getAuthToken caches access tokens from GAIA. Tokens expirations
are handled automatically, but if an access token goes bad for some other
reason, the application can call identity.invalidateAuthToken to remove
a bad token from the cache.

BUG=228908
(step #1 of the bug description)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195604

[Michael Courage, 2013-04-18 03:26:23]

This CL adds an in-memory token cache for access tokens retrieved by the
Identity API, and a new API call to remove bad tokens from the cache.

The token minting code in google_apis now parses and returns token expire times
from the response and auto-removes expired tokens.

If something else happens to the token (e.g. user revokes it manually on
accounts.google.com), the app will get 401s from its Google API calls, and
should call identity.invalidateAuthToken.

Suggested division of reviews:

dimich: chrome/browser/extensions/api/identity/identity_*
mpcomplete: chrome/common/extensions/api/experimental_identity.idl
    also OWNERS stamp for c/b/extensions 
zelidrag: google_apis/gaia/oauth2_mint_token_flow*
mpearson: histograms

[Mark P, 2013-04-18 15:06:51]

histograms.xml lgtm

[Matt Perry, 2013-04-18 17:46:36]

https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
File chrome/common/extensions/api/experimental_identity.idl (right):

https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
chrome/common/extensions/api/experimental_identity.idl:5: namespace
experimental.identity {
I hadn't seen this before, but we're trying to kill off the experimental
namespace. https://code.google.com/p/chromium/issues/detail?id=232888

Instead, prefer to add an entry to _permission_features.json with a channel
restriction to "dev". You can also whitelist certain extension IDs to work on
the stable channel if you want.

[Michael Courage, 2013-04-18 19:52:24]

https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
File chrome/common/extensions/api/experimental_identity.idl (right):

https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
chrome/common/extensions/api/experimental_identity.idl:5: namespace
experimental.identity {
On 2013/04/18 17:46:37, Matt Perry wrote:
> I hadn't seen this before, but we're trying to kill off the experimental
> namespace. https://code.google.com/p/chromium/issues/detail?id=232888
> 
> Instead, prefer to add an entry to _permission_features.json with a channel
> restriction to "dev". You can also whitelist certain extension IDs to work on
> the stable channel if you want.

The release of the Identity API has been blocked on web-based dialogs (which
this CL is part of). I'm planning to wrap up this change and then release the
API in M28.

I filed a separate bug to explicitly track removal of the prefix.
https://code.google.com/p/chromium/issues/detail?id=233250
Sounds good?

[Matt Perry, 2013-04-18 20:09:46]

On 2013/04/18 19:52:24, Michael Courage wrote:
>
https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
> File chrome/common/extensions/api/experimental_identity.idl (right):
> 
>
https://codereview.chromium.org/14329014/diff/6001/chrome/common/extensions/a...
> chrome/common/extensions/api/experimental_identity.idl:5: namespace
> experimental.identity {
> On 2013/04/18 17:46:37, Matt Perry wrote:
> > I hadn't seen this before, but we're trying to kill off the experimental
> > namespace. https://code.google.com/p/chromium/issues/detail?id=232888
> > 
> > Instead, prefer to add an entry to _permission_features.json with a channel
> > restriction to "dev". You can also whitelist certain extension IDs to work
on
> > the stable channel if you want.
> 
> The release of the Identity API has been blocked on web-based dialogs (which
> this CL is part of). I'm planning to wrap up this change and then release the
> API in M28.
> 
> I filed a separate bug to explicitly track removal of the prefix.
> https://code.google.com/p/chromium/issues/detail?id=233250
> Sounds good?

OK, LGTM

[Dmitry Titov, 2013-04-18 21:21:09]

I'd think naming-wise, "reportInvalidAuthToken()" would probably better describe
what this API is doing. It doesn't invalidates the token by itself, the token is
probably 'invalid' already due to external reasons (like user changing password
for example).

Or maybe 'reportAuthFailureWithToken(token)?

[Michael Courage, 2013-04-19 19:49:29]

On 2013/04/18 21:21:09, Dmitry Titov wrote:
> I'd think naming-wise, "reportInvalidAuthToken()" would probably better
describe
> what this API is doing. It doesn't invalidates the token by itself, the token
is
> probably 'invalid' already due to external reasons (like user changing
password
> for example).

renamed to removeCachedAuthToken

[Dmitry Titov, 2013-04-19 20:12:57]

lgtm

we probably need some review for the API change... Just in case folks have some
additional insights (if it already happened, it's great)

[zel, 2013-04-19 23:04:23]

lgtm

[commit-bot: I haz the power, 2013-04-19 23:20:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14329014/27001

[commit-bot: I haz the power, 2013-04-19 23:52:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 00:55:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14329014/27001

[commit-bot: I haz the power, 2013-04-20 02:18:31]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 19:43:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14329014/27001

[commit-bot: I haz the power, 2013-04-20 19:52:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-22 11:30:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14329014/27001

[commit-bot: I haz the power, 2013-04-22 11:30:16]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 510.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
49e93e9f3516170f6c152f0247871edab52c5ac0..7fff1883a88f5c227297364c437b8c399b6ef93d
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -510,6 +510,7 @@ enum HistogramValue {
   DEVELOPERPRIVATE_LOADPROJECT,
   COMMANDLINEPRIVATE_HASSWITCH,
   NETWORKINGPRIVATE_GETMANAGEDPROPERTIES,
+  EXPERIMENTAL_IDENTITY_REMOVECACHEDAUTHTOKEN,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-04-22 17:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/courage@chromium.org/14329014/16002

[commit-bot: I haz the power, 2013-04-22 21:28:34]

Change committed as 195604