Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
Committed: https://crrev.com/6b5d01a9e568040f653dd8e4e13f69d08d49af91
Cr-Commit-Position: refs/heads/master@{#361807}

[fdoray, 2015-11-09 05:00:12]

fdoray@chromium.org changed reviewers:
+ nduca@chromium.org

[fdoray, 2015-11-09 05:00:12]

Could you review this CL? Thanks.

[beaudoin, 2015-11-10 16:59:49]

Description was changed from

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
==========

to

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
==========

[nduca, 2015-11-20 19:35:24]

nduca@chromium.org changed reviewers:
+ oysteine@chromium.org

[nduca, 2015-11-20 19:35:24]

lgtm but lets ask oysteine for a review

[fdoray, 2015-11-23 13:53:59]

oysteine@: Can you review this CL?

[oystein (OOO til 10th of July), 2015-11-23 19:21:15]

https://codereview.chromium.org/1432873002/diff/20001/base/trace_event/common...
File base/trace_event/common/trace_event_common.h (right):

https://codereview.chromium.org/1432873002/diff/20001/base/trace_event/common...
base/trace_event/common/trace_event_common.h:488: #define
TRACE_COUNTER_WITH_TIMESTAMP1(category_group, name, value, timestamp) \
nit: the timestamp value should be before the optional args here (value,
value1_val, value2_name, etc), to be consistent with the other macros.

[fdoray, 2015-11-25 21:13:12]

oysteine@: Done. Can you take another look?

https://codereview.chromium.org/1432873002/diff/20001/base/trace_event/common...
File base/trace_event/common/trace_event_common.h (right):

https://codereview.chromium.org/1432873002/diff/20001/base/trace_event/common...
base/trace_event/common/trace_event_common.h:488: #define
TRACE_COUNTER_WITH_TIMESTAMP1(category_group, name, value, timestamp) \
On 2015/11/23 19:21:15, Oystein wrote:
> nit: the timestamp value should be before the optional args here (value,
> value1_val, value2_name, etc), to be consistent with the other macros.

Done.

[oystein (OOO til 10th of July), 2015-11-25 23:18:31]

lgtm

[fdoray, 2015-11-25 23:25:55]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2015-11-25 23:25:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nduca@chromium.org
Link to the patchset: https://codereview.chromium.org/1432873002/#ps40001
(title: "change order or macro args")

[commit-bot: I haz the power, 2015-11-25 23:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432873002/40001

[commit-bot: I haz the power, 2015-11-26 01:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 01:37:13]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[fdoray, 2015-11-26 02:00:34]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2015-11-26 02:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432873002/40001

[commit-bot: I haz the power, 2015-11-26 03:30:26]

Description was changed from

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
==========

to

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
==========

[commit-bot: I haz the power, 2015-11-26 03:30:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 03:31:09]

Description was changed from

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266
==========

to

==========
Add TRACE_COUNTER_WITH_TIMESTAMPx macros.

base::ProcessMetrics::GetCPUUsage() gives access to the % of CPU usage
for the current process in the time interval [a, b], where a is the
timestamp of the previous call to the method and b is the current
timestamp.

In order to display a correct CPU usage graph in about:tracing from the
values returned by base::ProcessMetrics::GetCPUUsage(), we need a way
to emit a counter event with timestamp |b| when we read the CPU usage at
timestamp |a|.

This CL introduces 2 TRACE_COUNTER_WITH_TIMESTAMPx macros that can emit
a counter event with a custom timestamp.

BUG=553266

Committed: https://crrev.com/6b5d01a9e568040f653dd8e4e13f69d08d49af91
Cr-Commit-Position: refs/heads/master@{#361807}
==========

[commit-bot: I haz the power, 2015-11-26 03:31:11]

Patchset 3 (id:??) landed as
https://crrev.com/6b5d01a9e568040f653dd8e4e13f69d08d49af91
Cr-Commit-Position: refs/heads/master@{#361807}