Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 143283015: Stack trace string should use dynamic script sourceURL if present. (Closed)

Created:
6 years, 10 months ago by vsevik
Modified:
6 years, 10 months ago
Reviewers:
dcarney, yurys
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Stack trace string should use dynamic script sourceURL if present. BUG=v8:2342 R=dcarney@chromium.org, yurys@chromium.org, yurys LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M src/messages.js View 1 chunk +4 lines, -8 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsevik
yurys@, could you please take a look? dcarney@, could you please OWNER review this?
6 years, 10 months ago (2014-02-11 13:49:17 UTC) #1
dcarney
lgtm
6 years, 10 months ago (2014-02-11 18:21:43 UTC) #2
yurys
lgtm
6 years, 10 months ago (2014-02-12 07:30:27 UTC) #3
alph
6 years, 10 months ago (2014-02-12 15:50:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19333 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698