Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/sweeper-thread.cc

Issue 143283002: Move the management of the already swept pages to MarkCompactCollector (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/mark-compact.cc ('K') | « src/sweeper-thread.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 27 matching lines...) Expand all
38 static const int kSweeperThreadStackSize = 64 * KB; 38 static const int kSweeperThreadStackSize = 64 * KB;
39 39
40 SweeperThread::SweeperThread(Isolate* isolate) 40 SweeperThread::SweeperThread(Isolate* isolate)
41 : Thread(Thread::Options("v8:SweeperThread", kSweeperThreadStackSize)), 41 : Thread(Thread::Options("v8:SweeperThread", kSweeperThreadStackSize)),
42 isolate_(isolate), 42 isolate_(isolate),
43 heap_(isolate->heap()), 43 heap_(isolate->heap()),
44 collector_(heap_->mark_compact_collector()), 44 collector_(heap_->mark_compact_collector()),
45 start_sweeping_semaphore_(0), 45 start_sweeping_semaphore_(0),
46 end_sweeping_semaphore_(0), 46 end_sweeping_semaphore_(0),
47 stop_semaphore_(0), 47 stop_semaphore_(0),
48 free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)),
49 free_list_old_pointer_space_(heap_->paged_space(OLD_POINTER_SPACE)),
50 private_free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)), 48 private_free_list_old_data_space_(heap_->paged_space(OLD_DATA_SPACE)),
51 private_free_list_old_pointer_space_( 49 private_free_list_old_pointer_space_(
52 heap_->paged_space(OLD_POINTER_SPACE)) { 50 heap_->paged_space(OLD_POINTER_SPACE)) {
53 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false)); 51 NoBarrier_Store(&stop_thread_, static_cast<AtomicWord>(false));
54 } 52 }
55 53
56 54
57 void SweeperThread::Run() { 55 void SweeperThread::Run() {
58 Isolate::SetIsolateThreadLocals(isolate_, NULL); 56 Isolate::SetIsolateThreadLocals(isolate_, NULL);
59 DisallowHeapAllocation no_allocation; 57 DisallowHeapAllocation no_allocation;
60 DisallowHandleAllocation no_handles; 58 DisallowHandleAllocation no_handles;
61 DisallowHandleDereference no_deref; 59 DisallowHandleDereference no_deref;
62 60
63 while (true) { 61 while (true) {
64 start_sweeping_semaphore_.Wait(); 62 start_sweeping_semaphore_.Wait();
65 63
66 if (Acquire_Load(&stop_thread_)) { 64 if (Acquire_Load(&stop_thread_)) {
67 stop_semaphore_.Signal(); 65 stop_semaphore_.Signal();
68 return; 66 return;
69 } 67 }
70 68
71 collector_->SweepInParallel(heap_->old_data_space(), 69 collector_->SweepInParallel(heap_->old_data_space(),
72 &private_free_list_old_data_space_, 70 &private_free_list_old_data_space_);
73 &free_list_old_data_space_);
74 collector_->SweepInParallel(heap_->old_pointer_space(), 71 collector_->SweepInParallel(heap_->old_pointer_space(),
75 &private_free_list_old_pointer_space_, 72 &private_free_list_old_pointer_space_);
76 &free_list_old_pointer_space_);
77 end_sweeping_semaphore_.Signal(); 73 end_sweeping_semaphore_.Signal();
78 } 74 }
79 } 75 }
80 76
81 77
82 intptr_t SweeperThread::StealMemory(PagedSpace* space) {
83 if (space->identity() == OLD_POINTER_SPACE) {
84 return space->free_list()->Concatenate(&free_list_old_pointer_space_);
85 } else if (space->identity() == OLD_DATA_SPACE) {
86 return space->free_list()->Concatenate(&free_list_old_data_space_);
87 }
88 return 0;
89 }
90
91
92 void SweeperThread::Stop() { 78 void SweeperThread::Stop() {
93 Release_Store(&stop_thread_, static_cast<AtomicWord>(true)); 79 Release_Store(&stop_thread_, static_cast<AtomicWord>(true));
94 start_sweeping_semaphore_.Signal(); 80 start_sweeping_semaphore_.Signal();
95 stop_semaphore_.Wait(); 81 stop_semaphore_.Wait();
96 Join(); 82 Join();
97 } 83 }
98 84
99 85
100 void SweeperThread::StartSweeping() { 86 void SweeperThread::StartSweeping() {
101 start_sweeping_semaphore_.Signal(); 87 start_sweeping_semaphore_.Signal();
102 } 88 }
103 89
104 90
105 void SweeperThread::WaitForSweeperThread() { 91 void SweeperThread::WaitForSweeperThread() {
106 end_sweeping_semaphore_.Wait(); 92 end_sweeping_semaphore_.Wait();
107 } 93 }
108 94
109 95
110 int SweeperThread::NumberOfThreads(int max_available) { 96 int SweeperThread::NumberOfThreads(int max_available) {
111 if (!FLAG_concurrent_sweeping && !FLAG_parallel_sweeping) return 0; 97 if (!FLAG_concurrent_sweeping && !FLAG_parallel_sweeping) return 0;
112 if (FLAG_sweeper_threads > 0) return FLAG_sweeper_threads; 98 if (FLAG_sweeper_threads > 0) return FLAG_sweeper_threads;
113 if (FLAG_concurrent_sweeping) return max_available - 1; 99 if (FLAG_concurrent_sweeping) return max_available - 1;
114 ASSERT(FLAG_parallel_sweeping); 100 ASSERT(FLAG_parallel_sweeping);
115 return max_available; 101 return max_available;
116 } 102 }
117 103
118 } } // namespace v8::internal 104 } } // namespace v8::internal
OLDNEW
« src/mark-compact.cc ('K') | « src/sweeper-thread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698