Issue 143283002: Move the management of the already swept pages to MarkCompactCollector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143283002: Move the management of the already swept pages to MarkCompactCollector (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move the management of the already swept pages to MarkCompactCollector That way, MCC doesn't need to know about the state the threads are in to steal free memory from them. BUG=v8:3104 R=hpayer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18706

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -29 lines)			Patch
M	src/heap.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mark-compact.h	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	src/mark-compact.cc	View	3 chunks	+14 lines, -6 lines	1 comment	Download
M	src/spaces.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/sweeper-thread.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/sweeper-thread.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, one nit. Please evaluate performance before committing this CL. https://codereview.chromium.org/143283002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/143283002/diff/1/src/mark-compact.cc#newcode594 ...

6 years, 11 months ago (2014-01-21 11:31:37 UTC) #2

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-21 11:41:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18706 (presubmit successful).

Expand Messages | Collapse Messages