Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 14328045: Revert 195187 "Revert 195143 "Prevent chrome.app JSON schema fro..." (Closed)

Created:
7 years, 8 months ago by not at google - send to devlin
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195187 "Revert 195143 "Prevent chrome.app JSON schema fro..." Last revert failed. Who knows why. > Revert 195143 "Prevent chrome.app JSON schema from loading on ev..." > > Small perf regression. > > > Prevent chrome.app JSON schema from loading on every page > > > > The app API along with app.window and app.runtime have been converted to use > > the feature system. Bindings are not added to the chrome object for unavailable > > APIs that are children of available APIs. For example, if chrome.app is > > available, we will not add lazy bindings to chrome for app.window and > > app.runtime. This eliminates the need to load the app schema, because we no > > longer need to get chrome.app to add the app.runtime and app.window bindings. > > > > BUG=55316 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194837 > > > > Review URL: https://chromiumcodereview.appspot.com/13604005 > > TBR=cduvall@chromium.org > > Review URL: https://codereview.chromium.org/14241030 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195199

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M trunk/src/chrome/common/extensions/api/_api_features.json View 3 chunks +24 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/app.json View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/extension_api_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
not at google - send to devlin
7 years, 8 months ago (2013-04-19 15:06:53 UTC) #1
not at google - send to devlin
7 years, 8 months ago (2013-04-19 15:07:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195199.

Powered by Google App Engine
This is Rietveld 408576698