Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: test/cctest/test-heap.cc

Issue 14328044: Update tests to use std::isnan instead of isnan (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/cctest/test-log.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 192
193 maybe_value = heap->NumberFromUint32(static_cast<uint32_t>(1) << 31); 193 maybe_value = heap->NumberFromUint32(static_cast<uint32_t>(1) << 31);
194 value = maybe_value->ToObjectChecked(); 194 value = maybe_value->ToObjectChecked();
195 CHECK(value->IsHeapNumber()); 195 CHECK(value->IsHeapNumber());
196 CHECK(value->IsNumber()); 196 CHECK(value->IsNumber());
197 CHECK_EQ(static_cast<double>(static_cast<uint32_t>(1) << 31), 197 CHECK_EQ(static_cast<double>(static_cast<uint32_t>(1) << 31),
198 value->Number()); 198 value->Number());
199 199
200 // nan oddball checks 200 // nan oddball checks
201 CHECK(heap->nan_value()->IsNumber()); 201 CHECK(heap->nan_value()->IsNumber());
202 CHECK(isnan(heap->nan_value()->Number())); 202 CHECK(std::isnan(heap->nan_value()->Number()));
203 203
204 Handle<String> s = FACTORY->NewStringFromAscii(CStrVector("fisk hest ")); 204 Handle<String> s = FACTORY->NewStringFromAscii(CStrVector("fisk hest "));
205 CHECK(s->IsString()); 205 CHECK(s->IsString());
206 CHECK_EQ(10, s->length()); 206 CHECK_EQ(10, s->length());
207 207
208 String* object_string = String::cast(heap->Object_string()); 208 String* object_string = String::cast(heap->Object_string());
209 CHECK( 209 CHECK(
210 Isolate::Current()->context()->global_object()->HasLocalProperty( 210 Isolate::Current()->context()->global_object()->HasLocalProperty(
211 object_string)); 211 object_string));
212 212
(...skipping 2846 matching lines...) Expand 10 before | Expand all | Expand 10 after
3059 } 3059 }
3060 // An entire block of handles has been filled. 3060 // An entire block of handles has been filled.
3061 // Next handle would require a new block. 3061 // Next handle would require a new block.
3062 ASSERT(data->next == data->limit); 3062 ASSERT(data->next == data->limit);
3063 3063
3064 DeferredHandleScope deferred(isolate); 3064 DeferredHandleScope deferred(isolate);
3065 DummyVisitor visitor; 3065 DummyVisitor visitor;
3066 isolate->handle_scope_implementer()->Iterate(&visitor); 3066 isolate->handle_scope_implementer()->Iterate(&visitor);
3067 deferred.Detach(); 3067 deferred.Detach();
3068 } 3068 }
OLDNEW
« no previous file with comments | « test/cctest/test-conversions.cc ('k') | test/cctest/test-log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698