Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 14328044: Update tests to use std::isnan instead of isnan (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Update tests to use std::isnan instead of isnan Should fix compilation breakage after r14352 Committed: http://code.google.com/p/v8/source/detail?r=14354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M test/cctest/test-api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-conversions.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
this fixes windows compilation for me plz review
7 years, 8 months ago (2013-04-19 14:13:42 UTC) #1
danno
lgtm
7 years, 8 months ago (2013-04-19 14:19:46 UTC) #2
danno
7 years, 8 months ago (2013-04-19 14:20:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698