EVDA: Modify V4L APIs for 3.8 kernel

EVDA: Modify V4L APIs for 3.8 kernel compatiblity

* Fill in v4l2_buffer.m.planes field for VIDIOC_DQBUF
* Support both V4L2_CID_GLOBAL_ALPHA and V4L2_CID_ALPHA_COMPONENT
  ioctls for setting GSC alpha.

BUG=230698
TEST=Ran VDA unittest on  snow with 3.8 kernel

Change-Id: Id633c4ed75ee807400536cea056e14a2d8ae5cf6

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203087

[Arun M, 2013-04-19 04:54:01]

Video playback on ToT chrome with 3.8 kernel failed. Had to make these changes
for VDAU to work on 3.8. Yet to test backward compatibility with 3.4 kernel.

[Ami GONE FROM CHROMIUM, 2013-05-21 07:06:07]

I am not competent to review this.  Presumably sheu@ is.
Arun: the earlier message in the reviewlog does not inspire confidence,
testing-wise.  Can you confirm that this does not regress shipping platforms?

[Arun M, 2013-05-21 07:44:27]

On 2013/05/21 07:06:07, Ami Fischman wrote:
> I am not competent to review this.  Presumably sheu@ is.
> Arun: the earlier message in the reviewlog does not inspire confidence,
> testing-wise.  Can you confirm that this does not regress shipping platforms?

I have tested vdau on snow with 3.8 kernel. Anyway this CL cannot go in until
3.8 kernel is the default.

[Pawel Osciak, 2013-05-21 16:00:32]

This cannot go in now, but only after 3.8 becomes the default, as you mentioned.

https://chromiumcodereview.appspot.com/14328033/diff/1/content/common/gpu/med...
File content/common/gpu/media/exynos_video_decode_accelerator.cc (right):

https://chromiumcodereview.appspot.com/14328033/diff/1/content/common/gpu/med...
content/common/gpu/media/exynos_video_decode_accelerator.cc:2069: control.id =
V4L2_CID_ALPHA_COMPONENT;
The driver in 3.4 doesn't handle this control, but the custom one that you are
changing it from (V4L2_CID_GLOBAL_ALPHA). This needs to be unified first.

[sheu, 2013-05-23 22:58:13]

Updated, PTAL.

I intend to land this, then land the 3.8->3.4 backport change on the kernel
side, then remove the compatibility conditional here.

[Ami GONE FROM CHROMIUM, 2013-05-23 23:01:26]

On 2013/05/23 22:58:13, sheu wrote:
> Updated, PTAL.
> 
> I intend to land this, then land the 3.8->3.4 backport change on the kernel
> side, then remove the compatibility conditional here.

What is "the compatibility conditional here"?

[sheu, 2013-05-23 23:03:04]

Inline comment in the patch.

https://chromiumcodereview.appspot.com/14328033/diff/13001/content/common/gpu...
File content/common/gpu/media/exynos_video_decode_accelerator.cc (right):

https://chromiumcodereview.appspot.com/14328033/diff/13001/content/common/gpu...
content/common/gpu/media/exynos_video_decode_accelerator.cc:2073: if
(HANDLE_EINTR(ioctl(gsc_fd_, VIDIOC_S_CTRL, &control)) != 0) {
This is the 3.4/3.8 compatibility bit.

[Pawel Osciak, 2013-05-23 23:04:38]

lgtm

[sheu, 2013-05-23 23:44:21]

On 2013/05/23 23:04:38, posciak wrote:
> lgtm

Just got an OWNERS checkoff to do.  fischman@: PTAL

[sheu, 2013-05-23 23:44:21]

On 2013/05/23 23:04:38, posciak wrote:
> lgtm

Just got an OWNERS checkoff to do.  fischman@: PTAL

[Ami GONE FROM CHROMIUM, 2013-05-30 01:15:01]

As I said earlier I'm not competent to actually review this.
Rubberstamp owners lgtm since I guess no owners is more competent here...

[commit-bot: I haz the power, 2013-05-30 03:19:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arun.m@samsung.com/14328033/13001

[commit-bot: I haz the power, 2013-05-30 05:52:00]

Change committed as 203087