Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc

Issue 14328031: Adding a minimize function for clicks on launcher items if only a single item (already active) is a… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added bounce animation in case of no minimize Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc
index 39c70c81cdecf43b05c41c166052bf1ab4066a80..ea6cc825b6317e41159de30ead5ebb46f04765d2 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc
@@ -70,6 +70,7 @@
#include "ui/aura/root_window.h"
#include "ui/aura/window.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/views/corewm/window_animations.h"
using extensions::Extension;
using content::WebContents;
@@ -873,6 +874,23 @@ const Extension* ChromeLauncherControllerPerApp::GetExtensionForAppID(
return profile_->GetExtensionService()->GetInstalledExtension(app_id);
}
+void ChromeLauncherControllerPerApp::ActivateWindowOrMinimizeIfActive(
+ BaseWindow* window,
+ bool allow_minimize) {
+ if (window->IsActive() && allow_minimize) {
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableMinimizeOnSecondLauncherItemClick)) {
+ AnimateWindow(window->GetNativeWindow(),
+ views::corewm::WINDOW_ANIMATION_TYPE_BOUNCE);
+ } else {
+ window->Minimize();
+ }
+ } else {
+ window->Show();
+ window->Activate();
+ }
+}
+
void ChromeLauncherControllerPerApp::OnBrowserShortcutClicked(
int event_flags) {
if (event_flags & ui::EF_CONTROL_DOWN) {
@@ -888,9 +906,8 @@ void ChromeLauncherControllerPerApp::OnBrowserShortcutClicked(
return;
}
- aura::Window* window = last_browser->window()->GetNativeWindow();
- window->Show();
- ash::wm::ActivateWindow(window);
+ ActivateWindowOrMinimizeIfActive(last_browser->window(),
+ GetBrowserApplicationList(0).size() == 2);
}
void ChromeLauncherControllerPerApp::ItemClicked(const ash::LauncherItem& item,

Powered by Google App Engine
This is Rietveld 408576698