Issue 14328030: Remove inline definition of SIZE_MAX in header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14328030: Remove inline definition of SIZE_MAX in header. (Closed)

Created:
7 years, 8 months ago by jln (very slow on Chromium)

Modified:
7 years, 8 months ago

Reviewers:
Nico

CC:
chromium-reviews, agl, jln+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove inline definition of SIZE_MAX in header. suid_unsafe_environment_variables.h is included both in C and C++ and is a little clunky. Clean things up a bit. BUG=233330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195066

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -10 lines)			Patch
	M	sandbox/linux/suid/common/suid_unsafe_environment_variables.h	View		3 chunks	+3 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

jln (very slow on Chromium)

Might be faster for you to just approve this and send to the CQ if ...

7 years, 8 months ago (2013-04-19 01:41:33 UTC) #1

Nico

lgtm This works for me too, thanks. (Another approach might be to define __STDC_LIMIT_MACROS in ...

7 years, 8 months ago (2013-04-19 03:01:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/14328030/1

7 years, 8 months ago (2013-04-19 03:01:58 UTC) #3

Nico

7 years, 8 months ago (2013-04-19 03:20:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r195066 (presubmit successful).