tools/pnacl-abicheck/LLVMBuild.txt - Issue 14328017: Fix CMake build

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/pnacl-abicheck/LLVMBuild.txt

Issue 14328017: Fix CMake build (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« lib/Target/Mips/CMakeLists.txt ('K') | « tools/pnacl-abicheck/CMakeLists.txt ('k') | no next file » | no next file with comments »

OLD	NEW
1 ;===- ./tools/pnacl-abicheck/LLVMBuild.txt ---------------------- Conf ---===;	1 ;===- ./tools/pnacl-abicheck/LLVMBuild.txt ---------------------- Conf ---===;

2 ;	2 ;

3 ; The LLVM Compiler Infrastructure	3 ; The LLVM Compiler Infrastructure

4 ;	4 ;

5 ; This file is distributed under the University of Illinois Open Source	5 ; This file is distributed under the University of Illinois Open Source

6 ; License. See LICENSE.TXT for details.	6 ; License. See LICENSE.TXT for details.

7 ;	7 ;

8 ;===------------------------------------------------------------------------===;	8 ;===------------------------------------------------------------------------===;

9 ;	9 ;

10 ; This is an LLVMBuild description file for the components in this subdirectory.	10 ; This is an LLVMBuild description file for the components in this subdirectory.

11 ;	11 ;

12 ; For more information on the LLVMBuild system, please see:	12 ; For more information on the LLVMBuild system, please see:

13 ;	13 ;

14 ; http://llvm.org/docs/LLVMBuild.html	14 ; http://llvm.org/docs/LLVMBuild.html

15 ;	15 ;

16 ;===------------------------------------------------------------------------===;	16 ;===------------------------------------------------------------------------===;

17	17

18 [component_0]	18 [component_0]

19 type = Tool	19 type = Tool

20 name = pnacl-abicheck	20 name = pnacl-abicheck

21 parent = Tools	21 parent = Tools

22 required_libraries = AsmParser BitReader	22 required_libraries = AsmParser BitReader NaClAnalysis
	eliben 2013/04/18 14:50:16 Isn't there some sort of naming inconsistency here Isn't there some sort of naming inconsistency here? Sometimes NaClAnalysis, sometimes naclanalysis [I'm not well familiar with the semantics of LLVMBuild.txt files] Derek Schuff 2013/04/18 16:15:53 Yes, and it's intentional. If I understand correct Show quoted text On 2013/04/18 14:50:16, eliben wrote: > Isn't there some sort of naming inconsistency here? Sometimes NaClAnalysis, > sometimes naclanalysis > > [I'm not well familiar with the semantics of LLVMBuild.txt files] Yes, and it's intentional. If I understand correctly, there are actually 2 completely different namespaces: One is defined in the name field of LLVMBuild.txt files and referred to by the required_libraries fields of other LLVMBuild.txt files. The other is defined by the library_name field and referred to by the CMakeLists.txt files (sometimes with "LLVM" prepended and sometimes not ಠ_ಠ). The capitalization is different, to make it clearer which names go together. Other components (e.g. Transforms/IPO and Ananlysis/IPA) are named this way as well.
OLD	NEW