Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

Issue 14328011: Remove hit test from dispatchDecidePolicyForNavigationAction (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: with rebaselines Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebKit/chromium/public/WebFrameClient.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
index 5e0c91b67ea5aa06d0d143048009b65c28914d45..7c6b91f6d5225bedb4f69e6606b3f2fa6a86712f 100644
--- a/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
+++ b/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
@@ -928,16 +928,7 @@ void FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction(
WebNavigationType webnavType =
WebDataSourceImpl::toWebNavigationType(action.type());
- RefPtr<Node> node;
- for (const Event* event = action.event(); event; event = event->underlyingEvent()) {
- if (event->isMouseEvent()) {
- const MouseEvent* mouseEvent =
- static_cast<const MouseEvent*>(event);
- node = m_webFrame->frame()->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation()).innerNonSharedNode();
- break;
- }
- }
- WebNode originatingNode(node);
+ WebNode originatingNode; // FIXME: Delete this when the decidePolicyForNavigation API is updated.
navigationPolicy = m_webFrame->client()->decidePolicyForNavigation(
m_webFrame, ds->request(), webnavType, originatingNode,
« no previous file with comments | « Source/WebKit/chromium/public/WebFrameClient.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698