Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14328010: Introduce more fine-grained OWNERS (Closed)

Created:
7 years, 8 months ago by abarth-chromium
Modified:
7 years, 8 months ago
CC:
blink-reviews, jamesr, jsbell, alecflett, abarth_chromum.org, kinuko, feature-media-reviews_chromium.org, dgrogan, haraken, Nate Chapin, jeez, jochen+watch_chromium.org
Visibility:
Public.

Description

Introduce more fine-grained OWNERS This CL is a first pass at creating more fine-grained OWNERS files for Blink. The general approach is to move the current set of top-level owners to the root of the Core directory. Rather than introduce fine-grained OWNERS within Core, this CL introduces owners for a number of the other modules. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148664

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Add some more OWNERS to Source/WebKit #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -40 lines) Patch
A LayoutTests/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ManualTests/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M OWNERS View 1 chunk +5 lines, -33 lines 0 comments Download
A PerformanceTests/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/Platform/OWNERS View 1 chunk +1 line, -3 lines 0 comments Download
A + Source/WebKit/OWNERS View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A Source/bindings/OWNERS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + Source/core/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/modules/OWNERS View 1 chunk +4 lines, -3 lines 0 comments Download
A Source/modules/donottrack/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/filesystem/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A Source/modules/indexeddb/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A Source/modules/mediasource/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/mediastream/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/quota/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/speech/OWNERS View 1 chunk +1 line, -0 lines 2 comments Download
A Source/modules/webaudio/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/webdatabase/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A Source/modules/websockets/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/wtf/OWNERS View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A Tools/DumpRenderTree/OWNERS View 1 chunk +1 line, -0 lines 2 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A Tools/GardeningServer/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A Tools/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A Tools/Scripts/OWNERS View 1 chunk +1 line, -0 lines 2 comments Download
A Tools/TestResultServer/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgrogan
https://codereview.chromium.org/14328010/diff/1/Source/modules/webdatabase/OWNERS File Source/modules/webdatabase/OWNERS (right): https://codereview.chromium.org/14328010/diff/1/Source/modules/webdatabase/OWNERS#newcode1 Source/modules/webdatabase/OWNERS:1: michealn@chromium.org spelling: michaeln
7 years, 8 months ago (2013-04-17 19:41:51 UTC) #1
abarth-chromium
https://codereview.chromium.org/14328010/diff/1/Source/modules/webdatabase/OWNERS File Source/modules/webdatabase/OWNERS (right): https://codereview.chromium.org/14328010/diff/1/Source/modules/webdatabase/OWNERS#newcode1 Source/modules/webdatabase/OWNERS:1: michealn@chromium.org On 2013/04/17 19:41:51, dgrogan wrote: > spelling: michaeln ...
7 years, 8 months ago (2013-04-17 20:02:18 UTC) #2
Stephen Chennney
https://codereview.chromium.org/14328010/diff/1027/Source/Platform/OWNERS File Source/Platform/OWNERS (right): https://codereview.chromium.org/14328010/diff/1027/Source/Platform/OWNERS#newcode4 Source/Platform/OWNERS:4: kbr@chromium.org schenney and pdr, please, for platform/graphics specifically.
7 years, 8 months ago (2013-04-17 20:19:16 UTC) #3
abarth-chromium
https://codereview.chromium.org/14328010/diff/1027/Source/Platform/OWNERS File Source/Platform/OWNERS (right): https://codereview.chromium.org/14328010/diff/1027/Source/Platform/OWNERS#newcode4 Source/Platform/OWNERS:4: kbr@chromium.org On 2013/04/17 20:19:16, Stephen Chenney wrote: > schenney ...
7 years, 8 months ago (2013-04-17 20:24:32 UTC) #4
Peter Beverloo
https://codereview.chromium.org/14328010/diff/29/Source/modules/speech/OWNERS File Source/modules/speech/OWNERS (right): https://codereview.chromium.org/14328010/diff/29/Source/modules/speech/OWNERS#newcode1 Source/modules/speech/OWNERS:1: hans@chromium.org Hans no longer works on speech/Chromium. tommyw@ works ...
7 years, 8 months ago (2013-04-17 21:12:38 UTC) #5
Dirk Pranke
https://codereview.chromium.org/14328010/diff/29/Tools/DumpRenderTree/OWNERS File Tools/DumpRenderTree/OWNERS (right): https://codereview.chromium.org/14328010/diff/29/Tools/DumpRenderTree/OWNERS#newcode1 Tools/DumpRenderTree/OWNERS:1: * I don't know that we really need "*" ...
7 years, 8 months ago (2013-04-17 21:21:02 UTC) #6
abarth-chromium
https://codereview.chromium.org/14328010/diff/29/Source/modules/speech/OWNERS File Source/modules/speech/OWNERS (right): https://codereview.chromium.org/14328010/diff/29/Source/modules/speech/OWNERS#newcode1 Source/modules/speech/OWNERS:1: hans@chromium.org On 2013/04/17 21:12:39, Peter Beverloo wrote: > Hans ...
7 years, 8 months ago (2013-04-17 21:56:22 UTC) #7
Dirk Pranke
On 2013/04/17 21:56:22, abarth wrote: > Yeah. Would you be willing to post a follow-up ...
7 years, 8 months ago (2013-04-17 22:13:05 UTC) #8
dglazkov
LGTM.
7 years, 8 months ago (2013-04-18 16:34:19 UTC) #9
abarth-chromium
7 years, 8 months ago (2013-04-18 16:36:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 manually as r148664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698