Issue 14328005: [Telemetry] Fix page_cycler benchmark on machines in positive timezones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14328005: [Telemetry] Fix page_cycler benchmark on machines in positive timezones. (Closed)

Created:
7 years, 8 months ago by tonyg

Modified:
7 years, 8 months ago

Reviewers:
dtu, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Fix page_cycler benchmark on machines in positive timezones. The creation date in GetChildPids is in the form <date>[-+]<timezone>. The old code only handled negative timezones. This updates it to handle both. BUG=232254 TEST=morejs page cycler on windows with timezone set to israel NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194686

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/core/chrome/win_platform_backend.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tonyg

7 years, 8 months ago (2013-04-17 21:34:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194686 (presubmit successful).

Expand Messages | Collapse Messages