Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 143273003: rebaseline_server: add bgcolor slider for pixelDiff column (Closed)

Created:
6 years, 10 months ago by epoger
Modified:
6 years, 10 months ago
Reviewers:
rmistry, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: add bgcolor slider for pixelDiff column BUG=skia:1904 NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=13325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M gm/rebaseline_server/static/loader.js View 1 chunk +36 lines, -0 lines 0 comments Download
M gm/rebaseline_server/static/view.html View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
epoger
Ready for review at patchset 1. Rob- please review the UI (and optionally the code). ...
6 years, 10 months ago (2014-02-05 17:25:52 UTC) #1
rmistry
LGTM+
6 years, 10 months ago (2014-02-05 17:28:48 UTC) #2
epoger
On 2014/02/05 17:28:48, rmistry wrote: > LGTM+ Thanks for the quick look, Ravi. I'll wait ...
6 years, 10 months ago (2014-02-05 17:29:27 UTC) #3
rmistry
On 2014/02/05 17:29:27, epoger wrote: > On 2014/02/05 17:28:48, rmistry wrote: > > LGTM+ > ...
6 years, 10 months ago (2014-02-05 17:34:02 UTC) #4
epoger
On 2014/02/05 17:34:02, rmistry wrote: > UI feedback (maybe not directly related to this CL): ...
6 years, 10 months ago (2014-02-05 17:39:05 UTC) #5
epoger
I'm gonna go ahead and commit this; I just realized that the server I had ...
6 years, 10 months ago (2014-02-05 19:48:58 UTC) #6
epoger
The CQ bit was checked by epoger@google.com
6 years, 10 months ago (2014-02-05 19:49:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/143273003/1
6 years, 10 months ago (2014-02-05 19:49:11 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 19:49:20 UTC) #9
Message was sent while issue was closed.
Change committed as 13325

Powered by Google App Engine
This is Rietveld 408576698