Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1432703002: Remove unused variables in Transform1bppBitmap. (Closed)

Created:
5 years, 1 month ago by rickyz (no longer on Chrome)
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rickyz (no longer on Chrome)
Hi, windows clang bots caught these unused variables.
5 years, 1 month ago (2015-11-04 22:02:30 UTC) #2
Tom Sepez
LGTM (provided it builds). Thanks!
5 years, 1 month ago (2015-11-04 22:12:16 UTC) #3
rickyz (no longer on Chrome)
Hm, I don't quite understand why, but the windows clang bots are trying to apply ...
5 years, 1 month ago (2015-11-04 22:19:56 UTC) #5
rickyz (no longer on Chrome)
Oops, just read the messages about the CQ not being supported - this is my ...
5 years, 1 month ago (2015-11-04 22:22:34 UTC) #7
Oliver Chang
Committed patchset #2 (id:20001) manually as 9e48432750f7d86a43c3d10f47a057f8360f7619 (presubmit successful).
5 years, 1 month ago (2015-11-04 22:25:10 UTC) #9
Oliver Chang
5 years, 1 month ago (2015-11-04 22:25:21 UTC) #10
Message was sent while issue was closed.
On 2015/11/04 22:22:34, rickyz wrote:
> Oops, just read the messages about the CQ not being supported - this is my
first
> non-webkit third party change, apparently. Mind landing this, Oliver? Thanks!

Done! One day we'll have a CQ...

Powered by Google App Engine
This is Rietveld 408576698