Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 14327014: Disable page zoom through control+scroll on Mac. (Closed)

Created:
7 years, 8 months ago by jam
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Disable page zoom through control+scroll on Mac. I accidentally enabled this on Mac in r181965. However on Mac this has an unintended consequence of changing the page zoom when the user starts inertial scrolling and presses control right after. BUG=178972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194942

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years, 8 months ago (2013-04-17 23:44:00 UTC) #1
Nico
lgtm for mac, thanks for the quick fix! I also noticed the same issue on ...
7 years, 8 months ago (2013-04-17 23:48:41 UTC) #2
jam
7 years, 8 months ago (2013-04-18 00:17:22 UTC) #3
On 2013/04/17 23:48:41, Nico wrote:
> lgtm for mac, thanks for the quick fix!
> 
> I also noticed the same issue on my Chromebook Pixel and found it slightly
> annoying: I'd two-finger-scroll a web page, and while it's still scrolling
press
> ctrl with the intent to ctrl-click a link to open it in a new tab, and the
zoom
> level changed. Maybe it's not a regression there though. Thoughts on CrOs?

I can't tell whether my change caused this or not, as I'm not setup for building
and testing on a cros device. I'll ping cros people about this.

> 
> I guess on Windows it's not an issue because two-finger-scroll trackpads
aren't
> as common there.

I think another issue to consider is whether the OS delivers these buffered
mouse wheel events with a control modifier or not. It seems odd that they would
come with the modifier even though the user never scrolled and held control at
the same time.

Powered by Google App Engine
This is Rietveld 408576698