Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: src/js/harmony-regexp.js

Issue 1432683002: Revert of Implement flag and source getters on RegExp.prototype. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@rproto
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/js/macros.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 6
7 'use strict'; 7 'use strict';
8 8
9 %CheckIsBootstrapping(); 9 %CheckIsBootstrapping();
10 10
11 // ------------------------------------------------------------------- 11 // -------------------------------------------------------------------
12 // Imports 12 // Imports
13 13
14 var GetRegExpFlagGetter = utils.ImportNow("GetRegExpFlagGetter");
15 var GlobalRegExp = global.RegExp; 14 var GlobalRegExp = global.RegExp;
16 var MakeTypeError; 15 var MakeTypeError;
17 16
18 utils.Import(function(from) { 17 utils.Import(function(from) {
19 MakeTypeError = from.MakeTypeError; 18 MakeTypeError = from.MakeTypeError;
20 }); 19 });
21 20
22 // ------------------------------------------------------------------- 21 // -------------------------------------------------------------------
23 22
24 // ES6 draft 12-06-13, section 21.2.5.3 23 // ES6 draft 12-06-13, section 21.2.5.3
25 // + https://bugs.ecmascript.org/show_bug.cgi?id=3423 24 // + https://bugs.ecmascript.org/show_bug.cgi?id=3423
26 function RegExpGetFlags() { 25 function RegExpGetFlags() {
27 if (!IS_SPEC_OBJECT(this)) { 26 if (!IS_SPEC_OBJECT(this)) {
28 throw MakeTypeError( 27 throw MakeTypeError(kFlagsGetterNonObject, TO_STRING(this));
29 kRegExpNonObject, "RegExp.prototype.flags", TO_STRING(this));
30 } 28 }
31 var result = ''; 29 var result = '';
32 if (this.global) result += 'g'; 30 if (this.global) result += 'g';
33 if (this.ignoreCase) result += 'i'; 31 if (this.ignoreCase) result += 'i';
34 if (this.multiline) result += 'm'; 32 if (this.multiline) result += 'm';
35 if (this.unicode) result += 'u'; 33 if (this.unicode) result += 'u';
36 if (this.sticky) result += 'y'; 34 if (this.sticky) result += 'y';
37 return result; 35 return result;
38 } 36 }
39 37
40 %DefineAccessorPropertyUnchecked(GlobalRegExp.prototype, 'flags', 38 %DefineAccessorPropertyUnchecked(GlobalRegExp.prototype, 'flags',
41 RegExpGetFlags, null, DONT_ENUM); 39 RegExpGetFlags, null, DONT_ENUM);
42 %SetNativeFlag(RegExpGetFlags); 40 %SetNativeFlag(RegExpGetFlags);
43 41
44 %DefineGetterPropertyUnchecked(GlobalRegExp.prototype, "sticky",
45 GetRegExpFlagGetter("RegExp.prototype.sticky", REGEXP_STICKY_MASK),
46 DONT_ENUM);
47
48 %DefineGetterPropertyUnchecked(GlobalRegExp.prototype, "unicode",
49 GetRegExpFlagGetter("RegExp.prototype.unicode", REGEXP_UNICODE_MASK),
50 DONT_ENUM);
51 }) 42 })
OLDNEW
« no previous file with comments | « src/heap/heap.h ('k') | src/js/macros.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698