Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1432683002: Revert of Implement flag and source getters on RegExp.prototype. (Closed)

Created:
5 years, 1 month ago by Michael Hablich
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rproto
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Implement flag and source getters on RegExp.prototype. (patchset #6 id:110001 of https://codereview.chromium.org/1419823010/ ) Reason for revert: Breaks Chromium tests and blocks the roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/124490 Original issue's description: > Implement flag and source getters on RegExp.prototype. > > R=littledan@chromium.org > BUG=v8:3715, v8:4528 > LOG=Y > > Committed: https://crrev.com/60e8877e161fe6175e19fafce2d6ed1c3999cdb1 > Cr-Commit-Position: refs/heads/master@{#31753} > > Committed: https://crrev.com/b5c80a31ad266eb38a0cf2ff756be59c66d34aa5 > Cr-Commit-Position: refs/heads/master@{#31773} > > Committed: https://crrev.com/85494e90bb63a3a9e19a1bf862cb6bfcb0162ee9 > Cr-Commit-Position: refs/heads/master@{#31782} TBR=littledan@chromium.org,jochen@chromium.org,ulan@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3715, v8:4528 Committed: https://crrev.com/a77aa3a2b4ad7bc89514421324899bc603b0d68c Cr-Commit-Position: refs/heads/master@{#31801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -224 lines) Patch
M include/v8.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M src/heap/heap.h View 6 chunks +5 lines, -2 lines 0 comments Download
M src/js/harmony-regexp.js View 3 chunks +1 line, -10 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -14 lines 0 comments Download
M src/js/prologue.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/regexp.js View 11 chunks +30 lines, -73 lines 0 comments Download
M src/js/string.js View 4 chunks +3 lines, -4 lines 0 comments Download
M src/js/symbol.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +29 lines, -8 lines 0 comments Download
D test/mjsunit/es6/regexp-flags.js View 1 chunk +0 lines, -49 lines 0 comments Download
M test/mjsunit/mirror-regexp.js View 3 chunks +32 lines, -21 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +14 lines, -20 lines 0 comments Download
M test/mjsunit/regress/regress-447561.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/test262/test262.status View 5 chunks +36 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/toString-expected.txt View 2 chunks +1 line, -2 lines 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Hablich
Created Revert of Implement flag and source getters on RegExp.prototype.
5 years, 1 month ago (2015-11-04 17:56:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432683002/1
5 years, 1 month ago (2015-11-04 17:56:45 UTC) #2
commit-bot: I haz the power
Failed to apply patch for src/bootstrapper.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 1 month ago (2015-11-04 17:57:02 UTC) #4
Michael Hablich
On 2015/11/04 17:57:02, commit-bot: I haz the power wrote: > Failed to apply patch for ...
5 years, 1 month ago (2015-11-04 18:23:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432683002/1
5 years, 1 month ago (2015-11-04 18:33:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 18:34:07 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 18:34:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a77aa3a2b4ad7bc89514421324899bc603b0d68c
Cr-Commit-Position: refs/heads/master@{#31801}

Powered by Google App Engine
This is Rietveld 408576698