Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1432663002: Add type-safe constructors to net::HashValue (Closed)

Created:
5 years, 1 month ago by pauljensen
Modified:
5 years ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type-safe constructors to net::HashValue BUG=551067 Committed: https://crrev.com/fef2e255d6178715eadd3ec320852c9020bf081d Cr-Commit-Position: refs/heads/master@{#363051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/base/hash_value.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/hash_value.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
eroman
Typo in CL description (constructors). Are you planning any code changes that use these new ...
5 years, 1 month ago (2015-11-07 01:30:23 UTC) #2
pauljensen
On 2015/11/07 01:30:23, eroman wrote: > Typo in CL description (constructors). Done, thanks. > > ...
5 years, 1 month ago (2015-11-07 01:33:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432663002/1
5 years ago (2015-12-03 18:48:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 20:48:21 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 20:49:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fef2e255d6178715eadd3ec320852c9020bf081d
Cr-Commit-Position: refs/heads/master@{#363051}

Powered by Google App Engine
This is Rietveld 408576698