Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 143263025: Add support to change the status header for gatekeeper-ng. (Closed)

Created:
6 years, 10 months ago by ghost stip (do not use)
Modified:
6 years, 10 months ago
Reviewers:
agable
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Add support to change the status header for gatekeeper-ng. BUG=340462 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=249525

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename to use status_header instead of status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M app_test.py View 1 1 chunk +19 lines, -0 lines 0 comments Download
M gatekeeper_mailer.py View 1 4 chunks +20 lines, -18 lines 0 comments Download
M mailer.py View 1 1 chunk +3 lines, -1 line 0 comments Download
A + tests/test_mailer/expected_status.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ghost stip (do not use)
ptal https://codereview.chromium.org/143263025/diff/1/gatekeeper_mailer.py File gatekeeper_mailer.py (left): https://codereview.chromium.org/143263025/diff/1/gatekeeper_mailer.py#oldcode49 gatekeeper_mailer.py:49: status_text = self.status_header % { we move these ...
6 years, 10 months ago (2014-02-03 23:48:56 UTC) #1
agable
LGTM. Only real comment is that you are inconsistent re: calling the field "status" vs. ...
6 years, 10 months ago (2014-02-06 03:50:50 UTC) #2
ghost stip (do not use)
The CQ bit was checked by stip@chromium.org
6 years, 10 months ago (2014-02-06 22:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/143263025/50001
6 years, 10 months ago (2014-02-06 22:52:57 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 22:53:22 UTC) #5
Message was sent while issue was closed.
Change committed as 249525

Powered by Google App Engine
This is Rietveld 408576698