Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 143263022: Fix short-circuiting logical and/or in HOptimizedGraphBuilder. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix short-circuiting logical and/or in HOptimizedGraphBuilder. R=jkummerow@chromium.org BUG=336148 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=19031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/hydrogen.cc View 1 chunk +8 lines, -5 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-336148.js View 1 chunk +24 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 10 months ago (2014-02-03 14:18:00 UTC) #1
Jakob Kummerow
lgtm
6 years, 10 months ago (2014-02-03 14:25:46 UTC) #2
Yang
6 years, 10 months ago (2014-02-03 14:29:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698