Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 143263017: Make api_strict_mode the default in AndroidCommands. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 9 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Make api_strict_mode the default in AndroidCommands. As far as I can tell, everything should be compatible now and this will remove spam from various logs. If anything major breaks we should be able to find and fix quickly or else revert this. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253955

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix more cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M build/android/gyp/util/build_device.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 4 chunks +5 lines, -16 lines 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/screenshot.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/backends/android/android_backend.py View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/adb_commands.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 9 months ago (2014-02-27 18:45:41 UTC) #1
Ami GONE FROM CHROMIUM
LGTM & makes the buildspam go away. Thanks.
6 years, 9 months ago (2014-02-27 19:14:53 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 9 months ago (2014-02-27 19:17:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/143263017/40001
6 years, 9 months ago (2014-02-27 19:18:58 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 22:50:47 UTC) #5
Message was sent while issue was closed.
Change committed as 253955

Powered by Google App Engine
This is Rietveld 408576698