Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 143263015: Add global_context field to GlobalObject in heap profiler. (Closed)

Created:
6 years, 10 months ago by alph
Modified:
6 years, 10 months ago
Reviewers:
ulan, yurys, loislo
CC:
v8-dev
Visibility:
Public.

Description

Add global_context field to GlobalObject in heap profiler. LOG=N R=ulan@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18942

Patch Set 1 #

Patch Set 2 : Added a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alph
ptal
6 years, 10 months ago (2014-01-29 17:16:41 UTC) #1
yurys
Test?
6 years, 10 months ago (2014-01-30 09:18:36 UTC) #2
yurys
lgtm
6 years, 10 months ago (2014-01-30 09:18:56 UTC) #3
alph
On 2014/01/30 09:18:36, yurys wrote: > Test? Done.
6 years, 10 months ago (2014-01-30 10:12:30 UTC) #4
yurys
Thank you! LGTM!
6 years, 10 months ago (2014-01-30 10:38:26 UTC) #5
ulan
lgtm
6 years, 10 months ago (2014-01-30 10:40:39 UTC) #6
alph
6 years, 10 months ago (2014-01-30 12:17:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r18942 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698