runtime/vm/debugger_ia32.cc - Issue 143263012: Ensure the debugger keeps a reference to code objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_ia32.cc

Issue 143263012: Ensure the debugger keeps a reference to code objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_ia32.cc

===================================================================

--- runtime/vm/debugger_ia32.cc (revision 31995)

+++ runtime/vm/debugger_ia32.cc (working copy)

@@ -50,8 +50,7 @@

case PcDescriptors::kRuntimeCall:

case PcDescriptors::kClosureCall:

case PcDescriptors::kReturn: {

- const Code& code =

- Code::Handle(Function::Handle(function_).unoptimized_code());

+ const Code& code = Code::Handle(code_);

saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);

CodePatcher::PatchStaticCallAt(pc_, code,

StubCode::BreakpointRuntimeEntryPoint());

@@ -72,8 +71,7 @@

case PcDescriptors::kClosureCall:

case PcDescriptors::kRuntimeCall:

case PcDescriptors::kReturn: {

- const Code& code =

- Code::Handle(Function::Handle(function_).unoptimized_code());

+ const Code& code = Code::Handle(code_);

CodePatcher::PatchStaticCallAt(pc_, code, saved_value_);

break;

}

« no previous file with comments | « runtime/vm/debugger_arm.cc ('k') | runtime/vm/debugger_mips.cc » ('j') | no next file with comments »