Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: runtime/vm/debugger.h

Issue 143263012: Ensure the debugger keeps a reference to code objects (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
===================================================================
--- runtime/vm/debugger.h (revision 31995)
+++ runtime/vm/debugger.h (working copy)
@@ -74,10 +74,10 @@
// function gets compiled as a regular function and as a closure.
class CodeBreakpoint {
public:
- CodeBreakpoint(const Function& func, intptr_t pc_desc_index);
+ CodeBreakpoint(const Code& code, intptr_t pc_desc_index);
~CodeBreakpoint();
- RawFunction* function() const { return function_; }
+ RawFunction* function() const;
uword pc() const { return pc_; }
intptr_t token_pos() const { return token_pos_; }
bool IsInternal() const { return src_bpt_ == NULL; }
@@ -105,7 +105,7 @@
void PatchCode();
void RestoreCode();
- RawFunction* function_;
+ RawCode* code_;
intptr_t pc_desc_index_;
intptr_t token_pos_;
uword pc_;
@@ -318,9 +318,10 @@
// Called from Runtime when a breakpoint in Dart code is reached.
void BreakpointCallback();
- // Returns true if there is at least one breakpoint set in func.
+ // Returns true if there is at least one breakpoint set in func or code.
// Checks for both user-defined and internal temporary breakpoints.
bool HasBreakpoint(const Function& func);
+ bool HasBreakpoint(const Code& code);
// Returns true if the call at address pc is patched to point to
// a debugger stub.
« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698