Source/core/rendering/svg/RenderSVGText.cpp - Issue 143263011: Convert SVG <text> and descendants to use RenderObject::isChildAllowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGText.cpp

Issue 143263011: Convert SVG <text> and descendants to use RenderObject::isChildAllowed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/RenderSVGTSpan.cpp ('K') | « Source/core/rendering/svg/RenderSVGTSpan.cpp ('k') | Source/core/rendering/svg/RenderSVGTextPath.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/RenderSVGText.cpp

diff --git a/Source/core/rendering/svg/RenderSVGText.cpp b/Source/core/rendering/svg/RenderSVGText.cpp

index 5f2d22f5745e5ee2ee2f9ebb1a80dce46132f55c..de5e2007abf94e1409bc6be9002e7daf3a7aa330 100644

--- a/Source/core/rendering/svg/RenderSVGText.cpp

+++ b/Source/core/rendering/svg/RenderSVGText.cpp

@@ -70,7 +70,7 @@ RenderSVGText::~RenderSVGText()

bool RenderSVGText::isChildAllowed(RenderObject* child, RenderStyle*) const

{

- return child->isInline() && !SVGRenderSupport::isEmptySVGInlineText(child);

+ return child->isSVGInline() || (child->isText() && !SVGRenderSupport::isEmptySVGInlineText(child));

}

RenderSVGText* RenderSVGText::locateRenderSVGTextAncestor(RenderObject* start)

« Source/core/rendering/svg/RenderSVGTSpan.cpp ('K') | « Source/core/rendering/svg/RenderSVGTSpan.cpp ('k') | Source/core/rendering/svg/RenderSVGTextPath.h » ('j') | no next file with comments »