Convert SVG <text> and descendants to use RenderObject::isChildAllowed

Convert SVG <text> and descendants to use RenderObject::isChildAllowed

BUG=337607
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165765

[Stephen Chennney, 2014-01-24 18:07:40]

lgtm

[commit-bot: I haz the power, 2014-01-24 18:08:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/143263011/1

[commit-bot: I haz the power, 2014-01-24 18:16:23]

Change committed as 165765

[pdr., 2014-01-24 18:28:41]

LGTM as well but we should be on the lookout for security bugs in this area.
Disallowed renderer children were not created before but now they will be.

https://codereview.chromium.org/143263011/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGTSpan.cpp (right):

https://codereview.chromium.org/143263011/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGTSpan.cpp:38: {
Should we add this here?

if (!RenderSVGInline::isChildAllowed(child, style))
    return false;

(Here, and elsewhere. See
https://docs.google.com/a/chromium.org/drawings/d/1nayJX5XcclYj_-blbVuakVNjVW...)

[fs, 2014-01-27 13:24:18]

On 2014/01/24 18:28:41, pdr wrote:
> LGTM as well but we should be on the lookout for security bugs in this area.
> Disallowed renderer children were not created before but now they will be.

Right.
 
>
https://codereview.chromium.org/143263011/diff/1/Source/core/rendering/svg/Re...
> File Source/core/rendering/svg/RenderSVGTSpan.cpp (right):
> 
>
https://codereview.chromium.org/143263011/diff/1/Source/core/rendering/svg/Re...
> Source/core/rendering/svg/RenderSVGTSpan.cpp:38: {
> Should we add this here?
> 
> if (!RenderSVGInline::isChildAllowed(child, style))
>     return false;
> 
> (Here, and elsewhere. See
>
https://docs.google.com/a/chromium.org/drawings/d/1nayJX5XcclYj_-blbVuakVNjVW...)

I think I'll do this for all cases where it makes sense (which will be most
cases I suppose.) Possibly together with a cleanup/commoning of the predicates.