Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1432623002: Roll GTM from svn r705 to git hash 4018783. (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
hans, stuartmorgan
CC:
chromium-reviews, Mark Mentovai, Avi (use Gerrit), Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll GTM from svn r705 to git hash 4018783. Also move it from the old google code mirror to the new github mirror. BUG=550066 R=hans@chromium.org, stuartmorgan@chromium.org TBR=stuartmorgan Committed: https://chromium.googlesource.com/chromium/src/+/715d86f26743c87859241b8e7276c5137abdef02

Patch Set 1 #

Patch Set 2 : ios #

Patch Set 3 : sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M DEPS View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/testing/ios_testing.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Nico
5 years, 1 month ago (2015-11-03 21:46:58 UTC) #2
hans
lgtm
5 years, 1 month ago (2015-11-03 21:48:22 UTC) #4
Nico
(third_party/google_toolbox_for_mac owners fyi: i'm moving us to a new gtm mirror on github, since the ...
5 years, 1 month ago (2015-11-03 21:55:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432623002/1
5 years, 1 month ago (2015-11-03 21:55:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/89592)
5 years, 1 month ago (2015-11-03 22:06:23 UTC) #9
Nico
tbr stuartmorgan for the ios/testing gyp change. (gn doesn't need this change 'cause it uses ...
5 years, 1 month ago (2015-11-03 22:24:12 UTC) #12
stuartmorgan
lgtm
5 years, 1 month ago (2015-11-03 22:45:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432623002/40001
5 years, 1 month ago (2015-11-04 00:21:13 UTC) #16
commit-bot: I haz the power
Failed to commit the patch.
5 years, 1 month ago (2015-11-04 00:42:33 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/715d86f26743c87859241b8e7276c5137abdef02 Cr-Commit-Position: refs/heads/master@{#357691}
5 years, 1 month ago (2015-11-04 00:57:00 UTC) #20
Nico
5 years, 1 month ago (2015-11-04 00:57:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
715d86f26743c87859241b8e7276c5137abdef02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698