Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 1432603007: Clean-up RemoveSuggestion and related codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment reflected Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_autofill_manager.cc
diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc
index 3100bddf4e6f0101715f8781cb68e6253c8cdd30..6aa0418e00ff0f66948f26ba44bac450b28244d2 100644
--- a/components/password_manager/core/browser/password_autofill_manager.cc
+++ b/components/password_manager/core/browser/password_autofill_manager.cc
@@ -258,8 +258,8 @@ bool PasswordAutofillManager::GetDeletionConfirmationText(
bool PasswordAutofillManager::RemoveSuggestion(const base::string16& value,
int identifier) {
- // http://crbug.com/329038
- NOTIMPLEMENTED();
+ // Password suggestions cannot be deleted this way.
+ // See http://crbug.com/329038#c15
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698