Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 1432603007: Clean-up RemoveSuggestion and related codes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment addressed. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_autofill_manager.h" 5 #include "components/password_manager/core/browser/password_autofill_manager.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/i18n/case_conversion.h" 9 #include "base/i18n/case_conversion.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 bool PasswordAutofillManager::GetDeletionConfirmationText( 251 bool PasswordAutofillManager::GetDeletionConfirmationText(
252 const base::string16& value, 252 const base::string16& value,
253 int identifier, 253 int identifier,
254 base::string16* title, 254 base::string16* title,
255 base::string16* body) { 255 base::string16* body) {
256 return false; 256 return false;
257 } 257 }
258 258
259 bool PasswordAutofillManager::RemoveSuggestion(const base::string16& value, 259 bool PasswordAutofillManager::RemoveSuggestion(const base::string16& value,
260 int identifier) { 260 int identifier) {
261 // http://crbug.com/329038
262 NOTIMPLEMENTED();
263 return false; 261 return false;
vabr (Chromium) 2015/11/06 10:57:40 Please add a comment referencing http://crbug.com/
264 } 262 }
265 263
266 void PasswordAutofillManager::ClearPreviewedForm() { 264 void PasswordAutofillManager::ClearPreviewedForm() {
267 password_manager_driver_->ClearPreviewedForm(); 265 password_manager_driver_->ClearPreviewedForm();
268 } 266 }
269 267
270 //////////////////////////////////////////////////////////////////////////////// 268 ////////////////////////////////////////////////////////////////////////////////
271 // PasswordAutofillManager, private: 269 // PasswordAutofillManager, private:
272 270
273 bool PasswordAutofillManager::GetPasswordAndRealmForUsername( 271 bool PasswordAutofillManager::GetPasswordAndRealmForUsername(
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 autofill::PasswordFormFillData* found_password) { 316 autofill::PasswordFormFillData* found_password) {
319 LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(key); 317 LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(key);
320 if (iter == login_to_password_info_.end()) 318 if (iter == login_to_password_info_.end())
321 return false; 319 return false;
322 320
323 *found_password = iter->second; 321 *found_password = iter->second;
324 return true; 322 return true;
325 } 323 }
326 324
327 } // namespace password_manager 325 } // namespace password_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698