build/toolchain/gcc_toolchain.gni - Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn set-but-unused nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/gcc_toolchain.gni

diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni

index 6746f5e0db9ffe5bd5c804553d99c2ad20aadce4..3af4ff3468e74afc986dd7aabf66a4f2da812bb2 100644

--- a/build/toolchain/gcc_toolchain.gni

+++ b/build/toolchain/gcc_toolchain.gni

@@ -347,12 +347,8 @@ template("gcc_toolchain") {

command = "$ld {{ldflags}} -o $unstripped_outfile -Wl,--start-group @$rspfile {{solibs}} -Wl,--end-group $libs_section_prefix {{libs}} $libs_section_postfix"

if (defined(invoker.strip)) {

- strip_command =

- "${invoker.strip} --strip-unneeded -o $outfile $unstripped_outfile"

- command += " && " + strip_command

- }

- if (defined(invoker.postlink)) {

- command += " && " + invoker.postlink

+ link_wrapper = rebase_path("//build/toolchain/gcc_link_wrapper.py")

+ command = "$python_path $link_wrapper --strip=${invoker.strip} --unstripped-file=$unstripped_outfile --output=$outfile -- $command"

}

description = "LINK $outfile"

rspfile_content = "{{inputs}}"

« no previous file with comments | « build/toolchain/gcc_link_wrapper.py ('k') | build/toolchain/nacl/BUILD.gn » ('j') | no next file with comments »