build/toolchain/nacl/BUILD.gn - Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/nacl/BUILD.gn

diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn

index bf31e846a97452b0558d00fc7fcd5f317460f1c4..060ece3d675b0805a15eb1bb6444552897782934 100644

--- a/build/toolchain/nacl/BUILD.gn

+++ b/build/toolchain/nacl/BUILD.gn

@@ -37,14 +37,8 @@ nacl_toolchain("newlib_pnacl") {

cxx = toolprefix + "clang++"

ar = toolprefix + "ar"

ld = cxx

- executable_extension = ".pexe.debug"

- finalize = toolprefix + "finalize"

- nonfinal_file =

- "{{root_out_dir}}/{{target_output_name}}${executable_extension}"

- finalized_file = "{{root_out_dir}}/{{target_output_name}}.pexe"

- postlink = "$finalize $nonfinal_file -o $finalized_file"

- link_outputs = [ finalized_file ]

+ strip = toolprefix + "finalize"

Dirk Pranke 2015/11/03 23:49:13 maybe add a comment here about why we're using the

Roland McGrath 2015/11/04 00:06:44 Done.

+ executable_extension = ".pexe"

}

nacl_toolchain("newlib_pnacl_nonsfi") {

« build/toolchain/gcc_link_wrapper.py ('K') | « build/toolchain/gcc_toolchain.gni ('k') | build/toolchain/nacl_toolchain.gni » ('j') | no next file with comments »