Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: remoting/webapp/build_template.gni

Issue 1432603003: GN: Avoid nontrivial shell commands in gcc_toolchain tool("link") (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn set-but-unused nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/client/plugin/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Keep in sync with 'remoting_webapp' target in remoting/remoting_client.gypi. 5 # Keep in sync with 'remoting_webapp' target in remoting/remoting_client.gypi.
6 6
7 import("//build/config/chrome_build.gni") 7 import("//build/config/chrome_build.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/util/version.gni") 9 import("//build/util/version.gni")
10 import("//remoting/remoting_locales.gni") 10 import("//remoting/remoting_locales.gni")
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 dr_generated_html_files = [ 190 dr_generated_html_files = [
191 background_html_output, 191 background_html_output,
192 message_window_html_output, 192 message_window_html_output,
193 wcs_sandbox_html_output, 193 wcs_sandbox_html_output,
194 main_html_output, 194 main_html_output,
195 public_session_html_output, 195 public_session_html_output,
196 "$target_gen_dir/credits.html", 196 "$target_gen_dir/credits.html",
197 ] 197 ]
198 198
199 if (enable_pnacl) { 199 if (enable_pnacl) {
200 pexe_dir = get_label_info( 200 pnacl_tc = "//build/toolchain/nacl:newlib_pnacl"
201 "//remoting/client/plugin:remoting_client_plugin_newlib(//build/to olchain/nacl:newlib_pnacl)", 201 pexe_label = "//remoting/client/plugin:remoting_client_plugin_newlib"
202 "root_out_dir") 202 pexe_dir = get_label_info("${pexe_label}($pnacl_tc)", "root_out_dir")
203 203
204 extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe" ] 204 extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe" ]
205 if (is_debug) { 205 if (is_debug) {
206 extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe.debug" ] 206 extra_files += [ "$pexe_dir/remoting_client_plugin_newlib.pexe.debug" ]
207 } 207 }
208 } 208 }
209 209
210 inputs = [ rebase_path("crd/manifest.json.jinja2", root_build_dir) ] + 210 inputs = [ rebase_path("crd/manifest.json.jinja2", root_build_dir) ] +
211 remoting_version_files + 211 remoting_version_files +
212 rebase_path(remoting_webapp_crd_files, root_build_dir) + 212 rebase_path(remoting_webapp_crd_files, root_build_dir) +
213 extra_files + dr_generated_html_files 213 extra_files + dr_generated_html_files
214 214
215 outputs = [ 215 outputs = [
216 zip_path, 216 zip_path,
217 ] 217 ]
218 218
219 deps = [ 219 deps = [
220 ":$locales_listfile", 220 ":$locales_listfile",
221 ":$background_html", 221 ":$background_html",
222 ":$message_window_html", 222 ":$message_window_html",
223 ":$wcs_sandbox_html", 223 ":$wcs_sandbox_html",
224 ":$public_session_html", 224 ":$public_session_html",
225 ":$main_html", 225 ":$main_html",
226 "//remoting/resources", 226 "//remoting/resources",
227 "//remoting/webapp:credits", 227 "//remoting/webapp:credits",
228 ] 228 ]
229 229
230 if (enable_pnacl) { 230 if (enable_pnacl) {
231 deps += [ "//remoting/client/plugin:remoting_client_plugin_newlib(//build/ toolchain/nacl:newlib_pnacl)" ] 231 deps += [ "${pexe_label}($pnacl_tc)" ]
232 if (is_debug) {
233 deps += [ "${pexe_label}_debug($pnacl_tc)" ]
234 }
232 } 235 }
233 236
234 # Create a file that contains a list of all the resource files needed 237 # Create a file that contains a list of all the resource files needed
235 # to build the webapp. This is needed to avoid problems on platforms that 238 # to build the webapp. This is needed to avoid problems on platforms that
236 # limit the size of a command line. 239 # limit the size of a command line.
237 file_list = "$target_gen_dir/${target_name}_files.txt" 240 file_list = "$target_gen_dir/${target_name}_files.txt"
238 files = [] 241 files = []
239 files += rebase_path(dr_generated_html_files, root_build_dir) 242 files += rebase_path(dr_generated_html_files, root_build_dir)
240 files += rebase_path(remoting_webapp_crd_files, root_build_dir) 243 files += rebase_path(remoting_webapp_crd_files, root_build_dir)
241 files += rebase_path(extra_files, root_build_dir) 244 files += rebase_path(extra_files, root_build_dir)
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 args += [ 541 args += [
539 "--files_listfile", 542 "--files_listfile",
540 rebase_path(file_list, root_build_dir), 543 rebase_path(file_list, root_build_dir),
541 ] 544 ]
542 args += [ 545 args += [
543 "--locales_listfile", 546 "--locales_listfile",
544 rebase_path(locales_listfile_output, root_build_dir), 547 rebase_path(locales_listfile_output, root_build_dir),
545 ] 548 ]
546 } 549 }
547 } 550 }
OLDNEW
« no previous file with comments | « remoting/client/plugin/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698