Return correct ActivationFrameAlignment for iOS simulator variants

Return correct ActivationFrameAlignment for iOS simulator variants

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1fc938ac92d8690936bd89fbc8aeee429e7bfb83

[Chinmay, 2015-11-03 20:00:09]

chinmaygarde@google.com changed reviewers:
+ cutchccutchan@google.com, rmacnak@google.com

[rmacnak, 2015-11-03 21:13:01]

https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos.cc
File runtime/vm/os_macos.cc (right):

https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos....
runtime/vm/os_macos.cc:152: #else
Let's avoid fall through.

#elif TARGET_ARCH_IA32
  return 16;  // iOS simulator
#elif TARGET_ARCH_X64
  return 16;  // iOS simulator
#else
#error Unimplemented

[Chinmay, 2015-11-03 21:20:55]

On 2015/11/03 at 21:13:01, rmacnak wrote:
>
https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos.cc
> File runtime/vm/os_macos.cc (right):
> 
>
https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos....
> runtime/vm/os_macos.cc:152: #else
> Let's avoid fall through.
> 
> #elif TARGET_ARCH_IA32
>   return 16;  // iOS simulator
> #elif TARGET_ARCH_X64
>   return 16;  // iOS simulator
> #else
> #error Unimplemented

I am not sure there is a supported _IA32 simulator, but ok.

[rmacnak, 2015-11-03 21:23:21]

On 2015/11/03 21:20:55, Chinmay wrote:
> On 2015/11/03 at 21:13:01, rmacnak wrote:
> >
>
https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos.cc
> > File runtime/vm/os_macos.cc (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/1432603002/diff/1/runtime/vm/os_macos....
> > runtime/vm/os_macos.cc:152: #else
> > Let's avoid fall through.
> > 
> > #elif TARGET_ARCH_IA32
> >   return 16;  // iOS simulator
> > #elif TARGET_ARCH_X64
> >   return 16;  // iOS simulator
> > #else
> > #error Unimplemented
> 
> I am not sure there is a supported _IA32 simulator, but ok.

LGTM

[Chinmay, 2015-11-03 21:25:09]

Committed patchset #2 (id:20001) manually as
1fc938ac92d8690936bd89fbc8aeee429e7bfb83 (presubmit successful).