Adding <keygen> Content Setting (Android UI)

chrome/browser/ui/android/website_settings_popup_android.cc

Index: chrome/browser/ui/android/website_settings_popup_android.cc
diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc
index e9cab3b4e706e27e06eba7a78c9d3c666b4ad18b..d0e59212f5a99571656878df5081e9d3a506d6df 100644
--- a/chrome/browser/ui/android/website_settings_popup_android.cc
+++ b/chrome/browser/ui/android/website_settings_popup_android.cc
@@ -102,6 +102,7 @@ void WebsiteSettingsPopupAndroid::SetPermissionInfo(
   permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_NOTIFICATIONS);
   permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_IMAGES);
   permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_JAVASCRIPT);
+  permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_KEYGEN);

[Finnur, 2015/11/11 10:25:45]

I don't quite understand how this list work and why it is only a subset of the
first-class types that we show...? For example, where are Cookies, Popups,
Fullscreen, and Protected Content?

Images are also listed here, even though they are not shown under Site Settings.

What is the deal?

[svaldez, 2015/11/19 17:50:25]

I think this is a slightly different UI than the Site Settings window? I don't
think KEYGEN needs to be implemented here.

[Finnur, 2015/12/01 23:19:57]

If I'm not mistaken, this is the gatekeeper for the information that shows when
you click on the lock/page icon for a given site (the origin info bubble). It
would be good to keep that in sync with the site settings UI, so I suspect
keygen *should* be listed here (and UI changes added to show keygen as well).
You should consult egm@ on this.

   permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_POPUPS);
 
   std::map<ContentSettingsType, ContentSetting>