chrome/browser/ui/android/website_settings_popup_android.cc - Issue 1432573002: Adding <keygen> Content Setting (Android UI)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/website_settings_popup_android.cc

Issue 1432573002: Adding <keygen> Content Setting (Android UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@keygen_ui

Patch Set: Fixing android typos. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/website_settings_popup_android.cc

diff --git a/chrome/browser/ui/android/website_settings_popup_android.cc b/chrome/browser/ui/android/website_settings_popup_android.cc

index 466fbfc99e613bbdb9e860ff4784b8031584be39..fb4a31cc2c15e3a00160fbb80a9de86897a237fb 100644

--- a/chrome/browser/ui/android/website_settings_popup_android.cc

+++ b/chrome/browser/ui/android/website_settings_popup_android.cc

@@ -106,6 +106,7 @@ void WebsiteSettingsPopupAndroid::SetPermissionInfo(

permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_IMAGES);

permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_JAVASCRIPT);

permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_POPUPS);

+ permissions_to_display.push_back(CONTENT_SETTINGS_TYPE_KEYGEN);

Finnur 2015/12/11 17:53:05 Don't you need code in the OIB bubble to show this

svaldez 2015/12/11 18:13:10 OIB bubble? This is just for displaying it in the

std::map<ContentSettingsType, ContentSetting>

user_specified_settings_to_display;