chrome/test/data/android/keygen.html - Issue 1432573002: Adding <keygen> Content Setting (Android UI)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/android/keygen.html

Issue 1432573002: Adding <keygen> Content Setting (Android UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@keygen_ui

Patch Set: Improve comment. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2

	3 <head>

	4 <title>Test page for key generation</title>

	5

	6 <script>

	7 var keygen = false;

	8

	9 function runKeygen() {

	10 if (window.location.search.indexOf('?') == -1) {

	11 document.getElementById('test_form').submit();

	12 } else {

	13 // Verify that the form submission includes a generated key.

	14 // We check for base64 'MIIC' to match the first 3 bytes: 0x30 0x82 0x02
	Finnur 2015/12/11 21:06:12 nit: Generally, comments should end with some punc nit: Generally, comments should end with some punctuation. More importantly, though, this comment doesn't explain to a casual reader how this check fits in the grand scheme of things. As-is this looks like debugging code that should be taken out, not something that would cause the test to fail if taken out.
	15 keygen = (window.location.search.indexOf('?key=MIIC') == 0)

	16 }

	17 }

	18

	19 function didKeygen() {

	20 return keygen;

	21 }

	22 </script>

	23 </head>

	24

	25 <body onload="runKeygen()">

	26 This page tries to use a keygen element when it is loaded.

	27 <form id='test_form'>

	28 <keygen name='key'>

	29 </form>

	30 </body>

	31

	32 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/ui/android/website_settings_popup_android.cc ('k') | no next file » | no next file with comments »