chrome/test/data/android/keygen.html - Issue 1432573002: Adding <keygen> Content Setting (Android UI)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/android/keygen.html

Issue 1432573002: Adding <keygen> Content Setting (Android UI) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@keygen_ui

Patch Set: Fixing android typos. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2

	3 <head>

	4 <title>Test page for key generation</title>

	5

	6 <script>

	7 var keygen = false;

	8

	9 function runKeygen() {

	10 if (window.location.search.indexOf('?') == -1) {

	11 document.getElementById('test_form').submit();

	12 } else {

	13 keygen = (window.location.search.indexOf('?key=MIIC') == 0)
	Finnur 2015/12/11 17:53:05 What's this used for? Should it be removed? What's this used for? Should it be removed? svaldez 2015/12/11 18:13:10 This verifies that the keygen element has either b Show quoted text On 2015/12/11 17:53:05, Finnur wrote: > What's this used for? Should it be removed? This verifies that the keygen element has either been blocked from generating a key or has created a key. I've added a comment. Finnur 2015/12/11 18:29:29 My point was that I don't see any code adding/chec My point was that I don't see any code adding/checking for MIIC. Is this for debugging? Probably shouldn't be checked in then. Finnur 2015/12/11 20:08:56 How this works should probably be documented in a How this works should probably be documented in a comment, since this is totally not obvious to a casual reader.
	14 }

	15 }

	16

	17 function didKeygen() {

	18 return keygen;

	19 }

	20 </script>

	21 </head>

	22

	23 <body onload="runKeygen()">

	24 This page tries to use a keygen element when it is loaded.

	25 <form id='test_form'>

	26 <keygen name='key'>

	27 </form>

	28 </body>

	29

	30 </html>

OLD	NEW