Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Unified Diff: util/win/command_line_test.cc

Issue 1432563003: win: crashpad_handler should create its own pipe name in ephemeral mode (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: --help Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/win/exception_handler_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/command_line_test.cc
diff --git a/util/win/command_line_test.cc b/util/win/command_line_test.cc
index 5dc9e901623cde281893f9a025ea92ed838d7d83..f395569766ad844b4987aec37b38fc572dca8bff 100644
--- a/util/win/command_line_test.cc
+++ b/util/win/command_line_test.cc
@@ -41,7 +41,7 @@ using ScopedLocalAlloc = base::ScopedGeneric<HLOCAL, LocalAllocTraits>;
// Calls AppendCommandLineArgument() for every argument in argv, then calls
// CommandLineToArgvW() to decode the string into a vector again, and compares
// the input and output.
-void AppendCommandLineArgumentTest(size_t argc, const wchar_t* argv[]) {
+void AppendCommandLineArgumentTest(size_t argc, const wchar_t* const argv[]) {
std::wstring command_line;
for (size_t index = 0; index < argc; ++index) {
AppendCommandLineArgument(argv[index], &command_line);
@@ -69,7 +69,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("simple");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"argument 1",
L"argument 2",
@@ -80,7 +80,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("path with spaces");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"argument1",
L"argument 2",
@@ -92,7 +92,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("argument with embedded quotation marks");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"argument1",
L"she said, \"you had me at hello\"",
@@ -104,7 +104,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("argument with unbalanced quotation marks");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"argument1",
L"argument\"2",
@@ -117,7 +117,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("argument ending with backslash");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"\\some\\directory with\\spaces\\",
L"argument2",
@@ -128,7 +128,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("empty argument");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"",
L"argument2",
@@ -139,7 +139,7 @@ TEST(CommandLine, AppendCommandLineArgument) {
{
SCOPED_TRACE("funny nonprintable characters");
- const wchar_t* kArguments[] = {
+ const wchar_t* const kArguments[] = {
L"child.exe",
L"argument 1",
L"argument\t2",
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/win/exception_handler_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698