Chromium Code Reviews Chromium Code Reviews
Issue
1432563003:
win: crashpad_handler should create its own pipe name in ephemeral mode (Closed)
Descriptionwin: crashpad_handler should create its own pipe name in ephemeral mode
Allowing the client to create its own pipe name string caused a race
between client and server. Instead, in this mode, the server now creates
the pipe name along with a pipe, and returns it to its client via a
--handshake-handle. This guarantees that by the time the client gets the
pipe name, the server has already created it.
Ephemeral mode is now implied by --handshake-handle. The --persistent
option is gone. --persistent mode is enabled when using --pipe-name.
BUG=crashpad:69
R=scottmg@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3e988865adb034df4b61aabd6e3683f68ef0a981
Patch Set 1 #Patch Set 2 : Self-review #Patch Set 3 : It's futile to pick and choose errors, retry on all #
Total comments: 6
Patch Set 4 : Less troublesome truncation #Patch Set 5 : Address review feedback #Patch Set 6 : Rebase #Patch Set 7 : --help #
Messages
Total messages: 6 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
