Treat failed access checks for @@toStringTag as undefined

Treat failed access checks for @@toStringTag as undefined

This matches the approach used for @@isConcatSpreadable, and seems to
match what Mozilla is planning to do in Firefox.

Given that there's already little compatibility around cross-origin toString
results, there seems to be little hazard in making this change even before
spec language hits the HTML spec.

BUG=v8:3502, v8:4289, chromium:532469
LOG=n

Committed: https://crrev.com/5ae9f846b4519524cb0dd83873207050bffc5be9
Cr-Commit-Position: refs/heads/master@{#31755}

[adamk, 2015-11-03 01:08:49]

Description was changed from

==========
Treat failed access checks for @@toStringTag as "undefined"

This matches the approach used for @@isConcatSpreadable, and seems to
match what Mozilla is planning to do in Firefox.

Given that there's already little compatibility around cross-origin toString
results, there seems to be little hazard in making this change even before
spec language hits the HTML spec.

BUG=v8:3502, v8:4289, chromium:532469
==========

to

==========
Treat failed access checks for @@toStringTag as undefined

This matches the approach used for @@isConcatSpreadable, and seems to
match what Mozilla is planning to do in Firefox.

Given that there's already little compatibility around cross-origin toString
results, there seems to be little hazard in making this change even before
spec language hits the HTML spec.

BUG=v8:3502, v8:4289, chromium:532469
==========

[adamk, 2015-11-03 01:09:37]

adamk@chromium.org changed reviewers:
+ caitpotter88@gmail.com, jochen@chromium.org, verwaest@chromium.org

[adamk, 2015-11-03 01:09:38]

verwaest, caitp: PTAL
jochen: for heap/OWNERS

[caitp (gmail), 2015-11-03 05:12:04]

On 2015/11/03 01:09:38, adamk wrote:
> verwaest, caitp: PTAL
> jochen: for heap/OWNERS

It looks okay to me for what you're wanting to do. I have no idea if it's
actually web-safe or not. I think, if Blink bindings are still using
FunctionTemplate::SetClassName(), it probably won't be an observable difference
anyways (minus most of the new builtins)

[jochen (gone - plz use gerrit), 2015-11-03 07:23:53]

heap/ lgtm

[Toon Verwaest, 2015-11-03 09:33:10]

lgtm

[adamk, 2015-11-03 16:21:09]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-11-03 16:21:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432543002/1

[commit-bot: I haz the power, 2015-11-03 16:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 16:23:36]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7359)

[adamk, 2015-11-03 16:24:24]

Description was changed from

==========
Treat failed access checks for @@toStringTag as undefined

This matches the approach used for @@isConcatSpreadable, and seems to
match what Mozilla is planning to do in Firefox.

Given that there's already little compatibility around cross-origin toString
results, there seems to be little hazard in making this change even before
spec language hits the HTML spec.

BUG=v8:3502, v8:4289, chromium:532469
==========

to

==========
Treat failed access checks for @@toStringTag as undefined

This matches the approach used for @@isConcatSpreadable, and seems to
match what Mozilla is planning to do in Firefox.

Given that there's already little compatibility around cross-origin toString
results, there seems to be little hazard in making this change even before
spec language hits the HTML spec.

BUG=v8:3502, v8:4289, chromium:532469
LOG=n
==========

[adamk, 2015-11-03 16:24:29]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-11-03 16:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432543002/1

[commit-bot: I haz the power, 2015-11-03 16:26:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-03 16:26:34]

Patchset 1 (id:??) landed as
https://crrev.com/5ae9f846b4519524cb0dd83873207050bffc5be9
Cr-Commit-Position: refs/heads/master@{#31755}