[turbofan] Fix new.target when a function is inlined to a constructor.

[turbofan] Fix new.target when a function is inlined to a constructor.

Committed: https://crrev.com/0ac0e52847e8bcfb5debe681b71f8a7659dac47d
Cr-Commit-Position: refs/heads/master@{#31754}

[Igor Sheludko, 2015-11-03 14:23:22]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-11-03 14:28:48]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-03 14:28:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432493003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432493003/20001

[Igor Sheludko, 2015-11-03 14:28:58]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2015-11-03 14:28:58]

PTAL

https://codereview.chromium.org/1432493003/diff/20001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1432493003/diff/20001/src/frames.cc#newcode760
src/frames.cc:760: DCHECK(!HasInlinedFrames());
In order to add this check I had to add some consts and to ensure that I did it
right I replaced "virtual" with "override" in the whole frames class hierarchy.

[Michael Starzinger, 2015-11-03 14:45:47]

LGTM. Can we haz test case?

https://codereview.chromium.org/1432493003/diff/20001/src/frames.cc
File src/frames.cc (right):

https://codereview.chromium.org/1432493003/diff/20001/src/frames.cc#newcode760
src/frames.cc:760: DCHECK(!HasInlinedFrames());
On 2015/11/03 14:28:58, Igor Sheludko wrote:
> In order to add this check I had to add some consts and to ensure that I did
it
> right I replaced "virtual" with "override" in the whole frames class
hierarchy.

This would actually be checked by the presubmit checks if we wouldn't have
disabled "readability/inheritance" there. I am all in favor if fixing this.

[commit-bot: I haz the power, 2015-11-03 14:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 14:58:04]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-11-03 15:53:09]

Added a test.

[Igor Sheludko, 2015-11-03 15:53:13]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-03 15:53:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432493003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432493003/40001

[commit-bot: I haz the power, 2015-11-03 16:15:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-03 16:15:42]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-11-03 16:18:26]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-11-03 16:18:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1432493003/#ps40001
(title: "Test added")

[commit-bot: I haz the power, 2015-11-03 16:18:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1432493003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1432493003/40001

[commit-bot: I haz the power, 2015-11-03 16:20:04]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-11-03 16:20:38]

Patchset 2 (id:??) landed as
https://crrev.com/0ac0e52847e8bcfb5debe681b71f8a7659dac47d
Cr-Commit-Position: refs/heads/master@{#31754}