Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1432483003: X87: Reland "[es6] Better support for built-ins subclassing." (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland "[es6] Better support for built-ins subclassing." port 4490ce85205d3504dc0bf444f5e8b3deb04cbb06 (r31701). original commit message: Original issue's description: > [es6] Better support for built-ins subclassing. > > Create proper initial map for original constructor (new.target) instead of doing prototype > transition on the base constructor's initial map. This approach fixes in-object slack tracking > for subclass instances. > This CL also fixes subclassing from String. > > BUG=v8:3101, v8:3330 > LOG=Y > > Committed: https://crrev.com/cd5f48302a502154a0106d12e3066bd563c6340c > Cr-Commit-Position: refs/heads/master@{#31680} It also fixes typed array map smashing done during typed array initialization. BUG= Committed: https://crrev.com/62acae2436733fcfcce684bfb9280f84cb508cbd Cr-Commit-Position: refs/heads/master@{#31704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/x87/builtins-x87.cc View 5 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-02 09:34:09 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-02 09:39:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432483003/1
5 years, 1 month ago (2015-11-02 09:39:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 09:59:51 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 10:00:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62acae2436733fcfcce684bfb9280f84cb508cbd
Cr-Commit-Position: refs/heads/master@{#31704}

Powered by Google App Engine
This is Rietveld 408576698