Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: cc/scheduler/scheduler.h

Issue 1432463002: cc: Track BeginMainFrame more precisely in CompositorTimingHistory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests. New tests to be added. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/compositor_timing_history_unittest.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index 58ad8000cc6128691198d87a916bb85d733bc768..31a19fc7f9b4390a567118e900b4d6c7f7c0f1ec 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -125,7 +125,11 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
return state_machine_.impl_latency_takes_priority();
}
- void NotifyBeginMainFrameStarted();
+ // Pass in a main_thread_start_time of base::TimeTicks() if it is not
+ // known (e.g. blink lives on a remote machine) to signal that the
+ // start time isn't known and should not be used for scheduling
+ // and statistics puposes.
Sami 2015/11/05 14:42:36 nit: I'm not sure if the remote machine example is
brianderson 2015/11/05 21:33:26 With STP, we can still get valid timestamps. I che
Sami 2015/11/06 11:27:49 Ah right, looks like I misread STP as passing in a
+ void NotifyBeginMainFrameStarted(base::TimeTicks main_thread_start_time);
base::TimeTicks LastBeginImplFrameTime();
@@ -173,6 +177,7 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
SchedulerStateMachine::BeginImplFrameDeadlineMode
begin_impl_frame_deadline_mode_;
BeginFrameTracker begin_impl_frame_tracker_;
+ BeginFrameArgs begin_main_frame_args_;
base::Closure begin_retro_frame_closure_;
base::Closure begin_impl_frame_deadline_closure_;
« no previous file with comments | « cc/scheduler/compositor_timing_history_unittest.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698