cc/scheduler/scheduler_state_machine.cc - Issue 1432463002: cc: Track BeginMainFrame more precisely in CompositorTimingHistory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine.cc

Issue 1432463002: cc: Track BeginMainFrame more precisely in CompositorTimingHistory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase; fix typo Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine.cc

diff --git a/cc/scheduler/scheduler_state_machine.cc b/cc/scheduler/scheduler_state_machine.cc

index d9ce7676f9eeca3dd2590d6b1ee9ab8cbd2a7132..01ac8cbb1cc2be98421dd455cabc1b330cd9c623 100644

--- a/cc/scheduler/scheduler_state_machine.cc

+++ b/cc/scheduler/scheduler_state_machine.cc

@@ -1035,7 +1035,7 @@ void SchedulerStateMachine::SetNeedsOneBeginImplFrame() {

}

void SchedulerStateMachine::NotifyReadyToCommit() {

- DCHECK(begin_main_frame_state_ == BEGIN_MAIN_FRAME_STATE_STARTED)

+ DCHECK_EQ(begin_main_frame_state_, BEGIN_MAIN_FRAME_STATE_STARTED)

<< AsValue()->ToString();

begin_main_frame_state_ = BEGIN_MAIN_FRAME_STATE_READY_TO_COMMIT;

// In commit_to_active_tree mode, commit should happen right after

@@ -1046,7 +1046,7 @@ void SchedulerStateMachine::NotifyReadyToCommit() {

}

void SchedulerStateMachine::BeginMainFrameAborted(CommitEarlyOutReason reason) {

- DCHECK_EQ(begin_main_frame_state_, BEGIN_MAIN_FRAME_STATE_SENT);

+ DCHECK_EQ(begin_main_frame_state_, BEGIN_MAIN_FRAME_STATE_STARTED);

switch (reason) {

case CommitEarlyOutReason::ABORTED_OUTPUT_SURFACE_LOST:

case CommitEarlyOutReason::ABORTED_NOT_VISIBLE:

« no previous file with comments | « cc/scheduler/scheduler.cc ('k') | cc/scheduler/scheduler_state_machine_unittest.cc » ('j') | no next file with comments »