Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: cc/scheduler/compositor_timing_history_unittest.cc

Issue 1432463002: cc: Track BeginMainFrame more precisely in CompositorTimingHistory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests. New tests to be added. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.h » ('j') | cc/scheduler/scheduler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/scheduler/compositor_timing_history.h" 5 #include "cc/scheduler/compositor_timing_history.h"
6 6
7 #include "cc/debug/rendering_stats_instrumentation.h" 7 #include "cc/debug/rendering_stats_instrumentation.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace cc { 10 namespace cc {
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 base::TimeDelta begin_main_frame_to_commit_duration = 56 base::TimeDelta begin_main_frame_to_commit_duration =
57 base::TimeDelta::FromMilliseconds(1); 57 base::TimeDelta::FromMilliseconds(1);
58 base::TimeDelta prepare_tiles_duration = base::TimeDelta::FromMilliseconds(2); 58 base::TimeDelta prepare_tiles_duration = base::TimeDelta::FromMilliseconds(2);
59 base::TimeDelta prepare_tiles_end_to_ready_to_activate_duration = 59 base::TimeDelta prepare_tiles_end_to_ready_to_activate_duration =
60 base::TimeDelta::FromMilliseconds(1); 60 base::TimeDelta::FromMilliseconds(1);
61 base::TimeDelta commit_to_ready_to_activate_duration = 61 base::TimeDelta commit_to_ready_to_activate_duration =
62 base::TimeDelta::FromMilliseconds(3); 62 base::TimeDelta::FromMilliseconds(3);
63 base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4); 63 base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4);
64 base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5); 64 base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5);
65 65
66 timing_history_.WillBeginMainFrame(); 66 timing_history_.WillBeginMainFrame(false);
67 timing_history_.BeginMainFrameStarted(Now());
67 AdvanceNowBy(begin_main_frame_to_commit_duration); 68 AdvanceNowBy(begin_main_frame_to_commit_duration);
68 // timing_history_.BeginMainFrameAborted(); 69 // timing_history_.BeginMainFrameAborted();
69 timing_history_.DidCommit(); 70 timing_history_.DidCommit();
70 timing_history_.WillPrepareTiles(); 71 timing_history_.WillPrepareTiles();
71 AdvanceNowBy(prepare_tiles_duration); 72 AdvanceNowBy(prepare_tiles_duration);
72 timing_history_.DidPrepareTiles(); 73 timing_history_.DidPrepareTiles();
73 AdvanceNowBy(prepare_tiles_end_to_ready_to_activate_duration); 74 AdvanceNowBy(prepare_tiles_end_to_ready_to_activate_duration);
74 timing_history_.ReadyToActivate(); 75 timing_history_.ReadyToActivate();
75 // Do not count idle time between notification and actual activation. 76 // Do not count idle time between notification and actual activation.
76 AdvanceNowBy(one_second); 77 AdvanceNowBy(one_second);
(...skipping 22 matching lines...) Expand all
99 base::TimeDelta begin_main_frame_to_commit_duration = 100 base::TimeDelta begin_main_frame_to_commit_duration =
100 base::TimeDelta::FromMilliseconds(1); 101 base::TimeDelta::FromMilliseconds(1);
101 base::TimeDelta prepare_tiles_duration = base::TimeDelta::FromMilliseconds(2); 102 base::TimeDelta prepare_tiles_duration = base::TimeDelta::FromMilliseconds(2);
102 base::TimeDelta prepare_tiles_end_to_ready_to_activate_duration = 103 base::TimeDelta prepare_tiles_end_to_ready_to_activate_duration =
103 base::TimeDelta::FromMilliseconds(1); 104 base::TimeDelta::FromMilliseconds(1);
104 base::TimeDelta commit_to_ready_to_activate_duration = 105 base::TimeDelta commit_to_ready_to_activate_duration =
105 base::TimeDelta::FromMilliseconds(3); 106 base::TimeDelta::FromMilliseconds(3);
106 base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4); 107 base::TimeDelta activate_duration = base::TimeDelta::FromMilliseconds(4);
107 base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5); 108 base::TimeDelta draw_duration = base::TimeDelta::FromMilliseconds(5);
108 109
109 timing_history_.WillBeginMainFrame(); 110 timing_history_.WillBeginMainFrame(false);
111 timing_history_.BeginMainFrameStarted(Now());
110 AdvanceNowBy(begin_main_frame_to_commit_duration); 112 AdvanceNowBy(begin_main_frame_to_commit_duration);
111 // BeginMainFrameAborted counts as a commit complete. 113 // BeginMainFrameAborted counts as a commit complete.
112 timing_history_.BeginMainFrameAborted(); 114 timing_history_.BeginMainFrameAborted();
113 timing_history_.WillPrepareTiles(); 115 timing_history_.WillPrepareTiles();
114 AdvanceNowBy(prepare_tiles_duration); 116 AdvanceNowBy(prepare_tiles_duration);
115 timing_history_.DidPrepareTiles(); 117 timing_history_.DidPrepareTiles();
116 AdvanceNowBy(prepare_tiles_end_to_ready_to_activate_duration); 118 AdvanceNowBy(prepare_tiles_end_to_ready_to_activate_duration);
117 timing_history_.ReadyToActivate(); 119 timing_history_.ReadyToActivate();
118 // Do not count idle time between notification and actual activation. 120 // Do not count idle time between notification and actual activation.
119 AdvanceNowBy(one_second); 121 AdvanceNowBy(one_second);
(...skipping 11 matching lines...) Expand all
131 EXPECT_EQ(commit_to_ready_to_activate_duration, 133 EXPECT_EQ(commit_to_ready_to_activate_duration,
132 timing_history_.CommitToReadyToActivateDurationEstimate()); 134 timing_history_.CommitToReadyToActivateDurationEstimate());
133 EXPECT_EQ(prepare_tiles_duration, 135 EXPECT_EQ(prepare_tiles_duration,
134 timing_history_.PrepareTilesDurationEstimate()); 136 timing_history_.PrepareTilesDurationEstimate());
135 EXPECT_EQ(activate_duration, timing_history_.ActivateDurationEstimate()); 137 EXPECT_EQ(activate_duration, timing_history_.ActivateDurationEstimate());
136 EXPECT_EQ(draw_duration, timing_history_.DrawDurationEstimate()); 138 EXPECT_EQ(draw_duration, timing_history_.DrawDurationEstimate());
137 } 139 }
138 140
139 } // namespace 141 } // namespace
140 } // namespace cc 142 } // namespace cc
OLDNEW
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.h » ('j') | cc/scheduler/scheduler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698