printing/metafile_skia_wrapper.cc - Issue 1432443004: Remove SkDevice and SkBaseDevice outside skia/ext/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/metafile_skia_wrapper.cc

Issue 1432443004: Remove SkDevice and SkBaseDevice outside skia/ext/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove commented-out code Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/metafile_skia_wrapper.cc

diff --git a/printing/metafile_skia_wrapper.cc b/printing/metafile_skia_wrapper.cc

index 90a9c7c72cf138c91968657ce07017a14222c22c..9df35efa180b30f38e35e26cae01ab961019c475 100644

--- a/printing/metafile_skia_wrapper.cc

+++ b/printing/metafile_skia_wrapper.cc

@@ -5,10 +5,10 @@

#include "printing/metafile_skia_wrapper.h"

#include "skia/ext/platform_device.h"

#include "skia/ext/refptr.h"

-#include "third_party/skia/include/core/SkCanvas.h"

-#include "third_party/skia/include/core/SkDevice.h"

#include "third_party/skia/include/core/SkMetaData.h"

+class SkCanvas;

Lei Zhang 2015/11/18 17:36:36 Is this even needed?

Tom Hudson 2015/11/18 17:50:56 Technically not, since we include platform_device

namespace printing {

namespace {