pkg/analysis_server/lib/src/server/driver.dart - Issue 1432423004: Send any logError() information to the IDE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 1432423004: Send any logError() information to the IDE. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add messages for all sendServerErrorNotification() invocations. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/lib/src/server/driver.dart

diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart

index 845a2618dc90c2301a77b0ee6b4625b5c08af995..1238a1c462cb5795c510623e2dc3a297897db557 100644

--- a/pkg/analysis_server/lib/src/server/driver.dart

+++ b/pkg/analysis_server/lib/src/server/driver.dart

@@ -453,7 +453,8 @@ class Driver implements ServerStarter {

dynamic exception, StackTrace stackTrace) {

service.logPriorityException(exception, stackTrace);

AnalysisServer analysisServer = socketServer.analysisServer;

- analysisServer.sendServerErrorNotification(exception, stackTrace);

+ analysisServer.sendServerErrorNotification(

+ 'Captured exception', exception, stackTrace);

throw exception;

};

Function printFunction = print == null